The GPIO pad community definition for Skylake does not set the pad_cfg_lock_offset member, leading to an "offset not defined for pad" error when trying to lock a pad config in gpio_non_smm_lock_pad(). This must be set to the offset of the first Pad Configuration Lock register within each GPIO communities register blocks which can be found in the GPIO sections of the processor I/O and PCH-H datasheets. References: Skylake-U/Y: Intel 332691 Sunrise Point-H: Intel 332996 Kaby Lake-U/Y: Intel 334659 Union Point-H: Intel 335193 Change-Id: I2991a7cbfb333d9fdda008cbb4cbc272aa508ef0 Signed-off-by: Nicholas Chin <nic.c3.14@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/90884 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com> |
||
|---|---|---|
| .. | ||
| amd | ||
| cavium | ||
| example/min86 | ||
| ibm/power9 | ||
| intel | ||
| mediatek | ||
| nvidia | ||
| qualcomm | ||
| rockchip | ||
| samsung | ||
| sifive | ||
| ti | ||
| ucb/riscv | ||
| xilinx | ||