erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs/starbook/*: Tidy GPIO comments for the TPM

Browse source 
This is a non-functional change, and only makes the GPIOs easier to read.

Change-Id: Ibd60b124efa4f5cb0688ee097574884b9912fb66
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87112
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sean Rhodes 2025-04-02 13:59:28 +01:00
commit f111588377
5 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/mainboard/starlabs/starbook/variants/adl/gpio.c
View file

@ -71,6 +71,9 @@ const struct pad_config gpio_table[] = {
PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */
PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */
/* TPM */
PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */
/* GPD2: LAN Wake */
PAD_NC(GPD2, NONE),
/* GPD6: Sleep A */
@ -272,8 +275,6 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_E9, NONE),
/* E10: PWD Amplifier Input */
PAD_NC(GPP_E10, NONE),
/* E11: TPM IRQ */
PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST),
/* E13: Not connected */
PAD_NC(GPP_E13, NONE),
/* E15: Not Connected */

5
src/mainboard/starlabs/starbook/variants/mtl/gpio.c
View file

@ -76,6 +76,9 @@ const struct pad_config gpio_table[] = {
PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* Platform Reset */
PAD_CFG_GPI_SCI(GPP_E16, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */
/* TPM */
PAD_CFG_GPI_APIC_LOW(GPP_F13, NONE, PLTRST), /* Interrupt */
/* V02: PCIE_WAKE_LAN */
PAD_NC(GPP_V02, NONE),
/* V06: GPD_6_SLP_A_N */
@ -325,8 +328,6 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_F11, NONE),
/* F12: */
PAD_NC(GPP_F12, NONE),
/* F13: TPM_IRQ */
PAD_CFG_GPI_APIC_LOW(GPP_F13, NONE, PLTRST),
/* F14: */
PAD_NC(GPP_F14, NONE),
/* F15: */

5
src/mainboard/starlabs/starbook/variants/rpl/gpio.c
View file

@ -73,6 +73,9 @@ const struct pad_config gpio_table[] = {
PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */
PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */
/* TPM */
PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */
/* GPD2: LAN Wake */
PAD_NC(GPD2, NONE),
/* GPD6: Sleep A */
@ -273,8 +276,6 @@ const struct pad_config gpio_table[] = {
PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),
/* E10: PWD Amplifier Input */
PAD_NC(GPP_E10, NONE),
/* E11: TPM IRQ */
PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST),
/* E13: Not connected */
PAD_NC(GPP_E13, NONE),
/* E15: Not Connected */

5
src/mainboard/starlabs/starbook/variants/tgl/gpio.c
View file

@ -62,6 +62,9 @@ const struct pad_config gpio_table[] = {
PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* C10 Gate */
PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* Platform Reset */
/* TPM */
PAD_CFG_GPI_APIC_LOW(GPP_C14, NONE, PLTRST), /* Interrupt */
/* GPD2: LAN_WAKE# */
PAD_NC(GPD2, NONE),
/* GPD6: SIO_SLP_A# */
@ -174,8 +177,6 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_C12, NONE),
/* C13: Not Connected */
PAD_NC(GPP_C13, NONE),
/* C14: TPM_IRQ */
PAD_CFG_NF(GPP_C14, NONE, DEEP, NF1),
/* C15: TPM_RST */
PAD_NC(GPP_C15, NONE),
/* C18: TOUCH_I2C_SDA */

5
src/mainboard/starlabs/starfighter/variants/rpl/gpio.c
View file

@ -83,6 +83,9 @@ const struct pad_config gpio_table[] = {
PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */
PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */
/* TPM */
PAD_CFG_GPI_APIC_LOW(GPP_D10, NONE, PLTRST), /* Interrupt */
/* GPD2: LAN Wake */
PAD_NC(GPD2, NONE),
/* GPD6: Sleep A */
@ -237,8 +240,6 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_D8, NONE),
/* D9: PWD_AMP_IN */
PAD_NC(GPP_D9, NONE),
/* D10: TPM_IRQ */
PAD_CFG_GPI_APIC_LOW(GPP_D10, NONE, PLTRST),
/* D12: ES8336_INT_N */
PAD_NC(GPP_D12, NONE),
/* D13: Wireless LAN Wake */