From f1115883779eb0a2c8394bfcf8838800c111243e Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 2 Apr 2025 13:59:28 +0100 Subject: [PATCH] mb/starlabs/starbook/*: Tidy GPIO comments for the TPM This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ibd60b124efa4f5cb0688ee097574884b9912fb66 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87112 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/starbook/variants/adl/gpio.c | 5 +++-- src/mainboard/starlabs/starbook/variants/mtl/gpio.c | 5 +++-- src/mainboard/starlabs/starbook/variants/rpl/gpio.c | 5 +++-- src/mainboard/starlabs/starbook/variants/tgl/gpio.c | 5 +++-- src/mainboard/starlabs/starfighter/variants/rpl/gpio.c | 5 +++-- 5 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index da27f69bd4..774440b044 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -71,6 +71,9 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */ PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */ + /* TPM */ + PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -272,8 +275,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), - /* E11: TPM IRQ */ - PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), /* E15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index 0339413c02..efe8de2325 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -76,6 +76,9 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* Platform Reset */ PAD_CFG_GPI_SCI(GPP_E16, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */ + /* TPM */ + PAD_CFG_GPI_APIC_LOW(GPP_F13, NONE, PLTRST), /* Interrupt */ + /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), /* V06: GPD_6_SLP_A_N */ @@ -325,8 +328,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_F11, NONE), /* F12: */ PAD_NC(GPP_F12, NONE), - /* F13: TPM_IRQ */ - PAD_CFG_GPI_APIC_LOW(GPP_F13, NONE, PLTRST), /* F14: */ PAD_NC(GPP_F14, NONE), /* F15: */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 4a328e6f66..042a24d0be 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -73,6 +73,9 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */ PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */ + /* TPM */ + PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -273,8 +276,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), - /* E11: TPM IRQ */ - PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), /* E15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index eb75e31af2..fab78cbafa 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -62,6 +62,9 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* C10 Gate */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* Platform Reset */ + /* TPM */ + PAD_CFG_GPI_APIC_LOW(GPP_C14, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -174,8 +177,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_C12, NONE), /* C13: Not Connected */ PAD_NC(GPP_C13, NONE), - /* C14: TPM_IRQ */ - PAD_CFG_NF(GPP_C14, NONE, DEEP, NF1), /* C15: TPM_RST */ PAD_NC(GPP_C15, NONE), /* C18: TOUCH_I2C_SDA */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index b9b08919ce..3f26ff7e19 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -83,6 +83,9 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */ PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */ + /* TPM */ + PAD_CFG_GPI_APIC_LOW(GPP_D10, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -237,8 +240,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_D8, NONE), /* D9: PWD_AMP_IN */ PAD_NC(GPP_D9, NONE), - /* D10: TPM_IRQ */ - PAD_CFG_GPI_APIC_LOW(GPP_D10, NONE, PLTRST), /* D12: ES8336_INT_N */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */