erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/mediatek/common/dp: Use DP_WRITE2BYTE if possible

Browse source 
This patch prevents wrong mask passing to mtk_dp_mask.

TEST=emerge-rauru coreboot, check FW screen

Change-Id: If8c801173089761db55992279045d053c60dcd86
Signed-off-by: Yidi Lin <yidilin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85918
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Yidi Lin 2025-01-09 16:09:01 +08:00
commit 89c3bb4b08
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/soc/mediatek/common/dp/dptx_hal.c
View file

@ -65,7 +65,7 @@ void dptx_hal_settu_setencoder(struct mtk_dp *mtk_dp)
mtk_dp_write_byte(mtk_dp, REG_303C_DP_ENCODER0_P0 + 1,
BIT(7), BIT(7));
DP_WRITE2BYTE(mtk_dp, REG_3040_DP_ENCODER0_P0, 0x2020);
mtk_dp_mask(mtk_dp, REG_3364_DP_ENCODER1_P0, 0x2020, 0xfff);
DP_WRITE2BYTE(mtk_dp, REG_3364_DP_ENCODER1_P0, 0x2020);
mtk_dp_write_byte(mtk_dp, REG_3300_DP_ENCODER1_P0 + 1,
0x2, BIT(1) | BIT(0));
mtk_dp_write_byte(mtk_dp, REG_3364_DP_ENCODER1_P0 + 1,

4
src/soc/mediatek/common/dp/dptx_hal_common.c
View file

@ -292,12 +292,12 @@ void dptx_hal_settu_sramrd_start(struct mtk_dp *mtk_dp, u16 value)
void dptx_hal_setsdp_downcnt_init_inhblanking(struct mtk_dp *mtk_dp, u16 value)
{
mtk_dp_mask(mtk_dp, REG_3364_DP_ENCODER1_P0, value, 0xfff);
DP_WRITE2BYTE(mtk_dp, REG_3364_DP_ENCODER1_P0, value);
}
void dptx_hal_setsdp_downcnt_init(struct mtk_dp *mtk_dp, u16 value)
{
mtk_dp_mask(mtk_dp, REG_3040_DP_ENCODER0_P0, value, 0xfff);
DP_WRITE2BYTE(mtk_dp, REG_3040_DP_ENCODER0_P0, value);
}
bool dptx_hal_auxread_bytes(struct mtk_dp *mtk_dp, u8 cmd, u32 dpcd_addr, size_t length,