erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

{ec,mb}/starlabs: Drop remnants of EC mirror flag

Browse source 
Commit 50b7976bb2 ("ec/starlabs/merlin: Remove ITE mirror
functionality") removed the mirror_flag param from the EC code, but
some remnants were left behind in the platform and mainboard code.
Drop these unused bits.

TEST=build/boot starlabs/starlite_adl

Change-Id: I6eb8c9a6ef8f92e2d92081b8451cef8d7246ff7e
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85870
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Matt DeVillier 2025-01-06 14:18:45 -06:00 • committed by Sean Rhodes
commit 6da56eeeab
9 changed files with 0 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/ec/starlabs/merlin/variants/apl/ecdefs.h
View file

@ -20,6 +20,5 @@
#define ECRAM_MAX_CHARGE dead_code_t(uint8_t)
#define ECRAM_FAN_MODE dead_code_t(uint8_t)
#define ECRAM_FAST_CHARGE dead_code_t(uint8_t)
#define ECRAM_MIRROR_FLAG 0x04
#endif

1
src/ec/starlabs/merlin/variants/cezanne/ecdefs.h
View file

@ -23,6 +23,5 @@
#define ECRAM_KBL_BRIGHTNESS 0x36
#define ECRAM_FN_LOCK_STATE 0x70
#define ECRAM_FAST_CHARGE dead_code_t(uint8_t)
#define ECRAM_MIRROR_FLAG 0x05
#endif

1
src/ec/starlabs/merlin/variants/glk/ecdefs.h
View file

@ -20,6 +20,5 @@
#define ECRAM_MAX_CHARGE dead_code_t(uint8_t)
#define ECRAM_FAN_MODE dead_code_t(uint8_t)
#define ECRAM_FAST_CHARGE dead_code_t(uint8_t)
#define ECRAM_MIRROR_FLAG 0x04
#endif

1
src/ec/starlabs/merlin/variants/glkr/ecdefs.h
View file

@ -23,6 +23,5 @@
#define ECRAM_MAX_CHARGE dead_code_t(uint8_t)
#define ECRAM_FAN_MODE dead_code_t(uint8_t)
#define ECRAM_FAST_CHARGE 0x18
#define ECRAM_MIRROR_FLAG dead_code_t(uint8_t)
#endif

1
src/ec/starlabs/merlin/variants/kbl/ecdefs.h
View file

@ -20,6 +20,5 @@
#define ECRAM_FN_CTRL_REVERSE 0x43
#define ECRAM_MAX_CHARGE dead_code_t(uint8_t)
#define ECRAM_FAST_CHARGE dead_code_t(uint8_t)
#define ECRAM_MIRROR_FLAG 0x04
#endif

1
src/ec/starlabs/merlin/variants/merlin/ecdefs.h
View file

@ -20,6 +20,5 @@
#define ECRAM_MAX_CHARGE 0x1a
#define ECRAM_FAN_MODE 0x1b
#define ECRAM_FAST_CHARGE dead_code_t(uint8_t)
#define ECRAM_MIRROR_FLAG 0x05
#endif

2
src/mainboard/starlabs/byte_adl/cmos.default
View file

@ -11,5 +11,3 @@ me_state=Disable
# Devices
wireless=Enable
webcam=Enable
# EC
mirror_flag=Disable

2
src/mainboard/starlabs/starlite_adl/cmos.default
View file

@ -13,5 +13,3 @@ wireless=Enable
webcam=Enable
camera=Enable
microphone=Enable
# EC
mirror_flag=Disable

2
src/mainboard/starlabs/starlite_adl/cmos.layout
View file

@ -33,8 +33,6 @@ entries
# coreboot config options: EC
600 2 e 6 max_charge
608 1 e 1 mirror_flag
6616 4 h 0 mirror_flag_counter
# coreboot config options: check sums
984 16 h 0 check_sum