From 6da56eeeab107c9e1ee82e476b92b29749b7110f Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Mon, 6 Jan 2025 14:18:45 -0600 Subject: [PATCH] {ec,mb}/starlabs: Drop remnants of EC mirror flag Commit 50b7976bb222 ("ec/starlabs/merlin: Remove ITE mirror functionality") removed the mirror_flag param from the EC code, but some remnants were left behind in the platform and mainboard code. Drop these unused bits. TEST=build/boot starlabs/starlite_adl Change-Id: I6eb8c9a6ef8f92e2d92081b8451cef8d7246ff7e Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/85870 Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- src/ec/starlabs/merlin/variants/apl/ecdefs.h | 1 - src/ec/starlabs/merlin/variants/cezanne/ecdefs.h | 1 - src/ec/starlabs/merlin/variants/glk/ecdefs.h | 1 - src/ec/starlabs/merlin/variants/glkr/ecdefs.h | 1 - src/ec/starlabs/merlin/variants/kbl/ecdefs.h | 1 - src/ec/starlabs/merlin/variants/merlin/ecdefs.h | 1 - src/mainboard/starlabs/byte_adl/cmos.default | 2 -- src/mainboard/starlabs/starlite_adl/cmos.default | 2 -- src/mainboard/starlabs/starlite_adl/cmos.layout | 2 -- 9 files changed, 12 deletions(-) diff --git a/src/ec/starlabs/merlin/variants/apl/ecdefs.h b/src/ec/starlabs/merlin/variants/apl/ecdefs.h index e4857aa027..cca0bdc1bd 100644 --- a/src/ec/starlabs/merlin/variants/apl/ecdefs.h +++ b/src/ec/starlabs/merlin/variants/apl/ecdefs.h @@ -20,6 +20,5 @@ #define ECRAM_MAX_CHARGE dead_code_t(uint8_t) #define ECRAM_FAN_MODE dead_code_t(uint8_t) #define ECRAM_FAST_CHARGE dead_code_t(uint8_t) -#define ECRAM_MIRROR_FLAG 0x04 #endif diff --git a/src/ec/starlabs/merlin/variants/cezanne/ecdefs.h b/src/ec/starlabs/merlin/variants/cezanne/ecdefs.h index 0c522cc845..6942c391a3 100644 --- a/src/ec/starlabs/merlin/variants/cezanne/ecdefs.h +++ b/src/ec/starlabs/merlin/variants/cezanne/ecdefs.h @@ -23,6 +23,5 @@ #define ECRAM_KBL_BRIGHTNESS 0x36 #define ECRAM_FN_LOCK_STATE 0x70 #define ECRAM_FAST_CHARGE dead_code_t(uint8_t) -#define ECRAM_MIRROR_FLAG 0x05 #endif diff --git a/src/ec/starlabs/merlin/variants/glk/ecdefs.h b/src/ec/starlabs/merlin/variants/glk/ecdefs.h index c97e252bf4..8130bd17d4 100644 --- a/src/ec/starlabs/merlin/variants/glk/ecdefs.h +++ b/src/ec/starlabs/merlin/variants/glk/ecdefs.h @@ -20,6 +20,5 @@ #define ECRAM_MAX_CHARGE dead_code_t(uint8_t) #define ECRAM_FAN_MODE dead_code_t(uint8_t) #define ECRAM_FAST_CHARGE dead_code_t(uint8_t) -#define ECRAM_MIRROR_FLAG 0x04 #endif diff --git a/src/ec/starlabs/merlin/variants/glkr/ecdefs.h b/src/ec/starlabs/merlin/variants/glkr/ecdefs.h index ecc117c990..038c378fb2 100644 --- a/src/ec/starlabs/merlin/variants/glkr/ecdefs.h +++ b/src/ec/starlabs/merlin/variants/glkr/ecdefs.h @@ -23,6 +23,5 @@ #define ECRAM_MAX_CHARGE dead_code_t(uint8_t) #define ECRAM_FAN_MODE dead_code_t(uint8_t) #define ECRAM_FAST_CHARGE 0x18 -#define ECRAM_MIRROR_FLAG dead_code_t(uint8_t) #endif diff --git a/src/ec/starlabs/merlin/variants/kbl/ecdefs.h b/src/ec/starlabs/merlin/variants/kbl/ecdefs.h index deda3ae362..5ba8ad64b1 100644 --- a/src/ec/starlabs/merlin/variants/kbl/ecdefs.h +++ b/src/ec/starlabs/merlin/variants/kbl/ecdefs.h @@ -20,6 +20,5 @@ #define ECRAM_FN_CTRL_REVERSE 0x43 #define ECRAM_MAX_CHARGE dead_code_t(uint8_t) #define ECRAM_FAST_CHARGE dead_code_t(uint8_t) -#define ECRAM_MIRROR_FLAG 0x04 #endif diff --git a/src/ec/starlabs/merlin/variants/merlin/ecdefs.h b/src/ec/starlabs/merlin/variants/merlin/ecdefs.h index d5caf8a9ae..8127027fcb 100644 --- a/src/ec/starlabs/merlin/variants/merlin/ecdefs.h +++ b/src/ec/starlabs/merlin/variants/merlin/ecdefs.h @@ -20,6 +20,5 @@ #define ECRAM_MAX_CHARGE 0x1a #define ECRAM_FAN_MODE 0x1b #define ECRAM_FAST_CHARGE dead_code_t(uint8_t) -#define ECRAM_MIRROR_FLAG 0x05 #endif diff --git a/src/mainboard/starlabs/byte_adl/cmos.default b/src/mainboard/starlabs/byte_adl/cmos.default index ddb2d289db..43a1394c07 100644 --- a/src/mainboard/starlabs/byte_adl/cmos.default +++ b/src/mainboard/starlabs/byte_adl/cmos.default @@ -11,5 +11,3 @@ me_state=Disable # Devices wireless=Enable webcam=Enable -# EC -mirror_flag=Disable diff --git a/src/mainboard/starlabs/starlite_adl/cmos.default b/src/mainboard/starlabs/starlite_adl/cmos.default index 353d551f38..c2c7adfe6a 100644 --- a/src/mainboard/starlabs/starlite_adl/cmos.default +++ b/src/mainboard/starlabs/starlite_adl/cmos.default @@ -13,5 +13,3 @@ wireless=Enable webcam=Enable camera=Enable microphone=Enable -# EC -mirror_flag=Disable diff --git a/src/mainboard/starlabs/starlite_adl/cmos.layout b/src/mainboard/starlabs/starlite_adl/cmos.layout index 668b2cadca..2f2ef41492 100644 --- a/src/mainboard/starlabs/starlite_adl/cmos.layout +++ b/src/mainboard/starlabs/starlite_adl/cmos.layout @@ -33,8 +33,6 @@ entries # coreboot config options: EC 600 2 e 6 max_charge -608 1 e 1 mirror_flag -6616 4 h 0 mirror_flag_counter # coreboot config options: check sums 984 16 h 0 check_sum