erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

util/chromeos/crosfirmware.sh: Fix download of ninja (baytrail) recovery

Browse source 
Because the name NINJA has 2 occurrences inside remote recovery.conf:
https://dl.google.com/dl/edgedl/chromeos/recovery/recovery.conf

Running 'crosfirmware.sh ninja' will list both NINJA and VORTININJA
"file= & url=" with a total of 4 lines instead of 2. Since the script
by default uses the last 2 lines it will prefer VORTININJA and download
the Octopus MEEP recovery image instead while NINJA was requested.

By adjusting 'grep' its matching control by adding '-w' restores the
correct behaviour of only showing 2 lines for the requested image.
Both NINJA, VORTININJA and a third recovery image TIDUS still download
and extract correctly when applying this fix.

TEST=crosfirmware.sh ninja #downloads and extract correct image

Change-Id: I9b55c5a2626339e70f0ada9b80c9488a5580d371
Signed-off-by: Walter Sonius <walterav1984@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/89168
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Walter Sonius 2025-09-14 12:04:46 +02:00 • committed by Matt DeVillier
commit 59cbb073c2
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
util/chromeos/crosfirmware.sh
View file

@ -171,7 +171,7 @@ elif [ "$BOARD" != "" ]; then
get_inventory $CONF
echo Processing board $BOARD
eval $(grep -i $BOARD -A8 $CONF | grep '\(url=\|file=\)')
eval $(grep -i -w $BOARD -A8 $CONF | grep '\(url=\|file=\)')
do_one_board $BOARD $url $file
rm "$CONF"