From 59cbb073c22b366a760fbd8e88f7ae16ae96b54e Mon Sep 17 00:00:00 2001 From: Walter Sonius Date: Sun, 14 Sep 2025 12:04:46 +0200 Subject: [PATCH] util/chromeos/crosfirmware.sh: Fix download of ninja (baytrail) recovery Because the name NINJA has 2 occurrences inside remote recovery.conf: https://dl.google.com/dl/edgedl/chromeos/recovery/recovery.conf Running 'crosfirmware.sh ninja' will list both NINJA and VORTININJA "file= & url=" with a total of 4 lines instead of 2. Since the script by default uses the last 2 lines it will prefer VORTININJA and download the Octopus MEEP recovery image instead while NINJA was requested. By adjusting 'grep' its matching control by adding '-w' restores the correct behaviour of only showing 2 lines for the requested image. Both NINJA, VORTININJA and a third recovery image TIDUS still download and extract correctly when applying this fix. TEST=crosfirmware.sh ninja #downloads and extract correct image Change-Id: I9b55c5a2626339e70f0ada9b80c9488a5580d371 Signed-off-by: Walter Sonius Reviewed-on: https://review.coreboot.org/c/coreboot/+/89168 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- util/chromeos/crosfirmware.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh index 6dbac40394..673f3b38a5 100755 --- a/util/chromeos/crosfirmware.sh +++ b/util/chromeos/crosfirmware.sh @@ -171,7 +171,7 @@ elif [ "$BOARD" != "" ]; then get_inventory $CONF echo Processing board $BOARD - eval $(grep -i $BOARD -A8 $CONF | grep '\(url=\|file=\)') + eval $(grep -i -w $BOARD -A8 $CONF | grep '\(url=\|file=\)') do_one_board $BOARD $url $file rm "$CONF"