erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sb/intel/common/firmware/Makefile.mk: fix INTEL_IFD_SET_TOP_SWAP_BOOTBLOCK_SIZE

Browse source 
Halfway through the review of CB:89493 (commit 6e45016610 ("intel
soc,southbridge: Add Kconfig to set TSBS in IFD during build")) the
option was renamed and lost "CONFIG_" prefix in the Makefile.  Add the
missing prefix.

The omission was discovered and the fix tested while trying to use this
option on Protectli VP6670 where incorrect Top Swap size prevented a
boot.

Adding a missing space while at it.

Change-Id: Ie85fc0b81b2231760878306cf065598bec390e9f
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90432
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sergii Dmytruk 2025-12-09 00:48:13 +02:00 • committed by Matt DeVillier
commit 41348477e3
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/southbridge/intel/common/firmware/Makefile.mk
View file

@ -47,7 +47,7 @@ ifeq ($(CONFIG_HAVE_EC_BIN),y)
add_intel_firmware: $(call strip_quotes,$(CONFIG_EC_BIN_PATH))
endif
add_intel_firmware: $(obj)/coreboot.pre $(IFDTOOL)
ifeq ($(INTEL_IFD_SET_TOP_SWAP_BOOTBLOCK_SIZE),y)
ifeq ($(CONFIG_INTEL_IFD_SET_TOP_SWAP_BOOTBLOCK_SIZE),y)
printf " IFDTOOL Modifying top swap PCH strap in IFD\n"
printf " $(IFDTOOL_USE_CHIPSET)"
$(objutil)/ifdtool/ifdtool \
@ -56,7 +56,7 @@ ifeq ($(INTEL_IFD_SET_TOP_SWAP_BOOTBLOCK_SIZE),y)
-O $(obj)/ifd_custom_tsbs \
$(IFD_BIN_PATH)
printf " DD Adding Intel Firmware Descriptor\n"
dd if=$(obj)/ifd_custom_tsbs\
dd if=$(obj)/ifd_custom_tsbs \
of=$(obj)/coreboot.pre conv=notrunc >/dev/null 2>&1
else
printf " DD Adding Intel Firmware Descriptor\n"