From 41348477e3aaad93dd9e85b7846f984c73875e8f Mon Sep 17 00:00:00 2001 From: Sergii Dmytruk Date: Tue, 9 Dec 2025 00:48:13 +0200 Subject: [PATCH] sb/intel/common/firmware/Makefile.mk: fix INTEL_IFD_SET_TOP_SWAP_BOOTBLOCK_SIZE Halfway through the review of CB:89493 (commit 6e4501661095 ("intel soc,southbridge: Add Kconfig to set TSBS in IFD during build")) the option was renamed and lost "CONFIG_" prefix in the Makefile. Add the missing prefix. The omission was discovered and the fix tested while trying to use this option on Protectli VP6670 where incorrect Top Swap size prevented a boot. Adding a missing space while at it. Change-Id: Ie85fc0b81b2231760878306cf065598bec390e9f Signed-off-by: Sergii Dmytruk Reviewed-on: https://review.coreboot.org/c/coreboot/+/90432 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/southbridge/intel/common/firmware/Makefile.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/southbridge/intel/common/firmware/Makefile.mk b/src/southbridge/intel/common/firmware/Makefile.mk index 41ccca41d9..3c7ad906e6 100644 --- a/src/southbridge/intel/common/firmware/Makefile.mk +++ b/src/southbridge/intel/common/firmware/Makefile.mk @@ -47,7 +47,7 @@ ifeq ($(CONFIG_HAVE_EC_BIN),y) add_intel_firmware: $(call strip_quotes,$(CONFIG_EC_BIN_PATH)) endif add_intel_firmware: $(obj)/coreboot.pre $(IFDTOOL) -ifeq ($(INTEL_IFD_SET_TOP_SWAP_BOOTBLOCK_SIZE),y) +ifeq ($(CONFIG_INTEL_IFD_SET_TOP_SWAP_BOOTBLOCK_SIZE),y) printf " IFDTOOL Modifying top swap PCH strap in IFD\n" printf " $(IFDTOOL_USE_CHIPSET)" $(objutil)/ifdtool/ifdtool \ @@ -56,7 +56,7 @@ ifeq ($(INTEL_IFD_SET_TOP_SWAP_BOOTBLOCK_SIZE),y) -O $(obj)/ifd_custom_tsbs \ $(IFD_BIN_PATH) printf " DD Adding Intel Firmware Descriptor\n" - dd if=$(obj)/ifd_custom_tsbs\ + dd if=$(obj)/ifd_custom_tsbs \ of=$(obj)/coreboot.pre conv=notrunc >/dev/null 2>&1 else printf " DD Adding Intel Firmware Descriptor\n"