erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/pantherlake: Correct function naming and code style

Browse source 
Commit f3211e9639 ("soc/intel/pantherlake: Add support for Acoustic
Noise Mitigation UPDs") introduced minor coding convention
violations. These are being addressed as follows:

- Renames fill_fsps_acoustic_params to fill_fspm_acoustic_params to
  align with the naming conventions used for other FSP-M configuration
  functions.
- Removes an unnecessary empty line.
- Aligns function parameters.

Change-Id: I8652c2fee71c8e2742146b5e622633de78c1c17e
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/89332
Reviewed-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Bora Guvendik <bora.guvendik@intel.corp-partner.google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Pranava Y N <pranavayn@google.com>
This commit is contained in:
Jeremy Compostella 2025-09-24 13:56:39 -07:00 • committed by Jérémy Compostella
commit 3a84c93b5b
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/soc/intel/pantherlake/romstage/fsp_params.c
View file

@ -356,8 +356,8 @@ void platform_display_early_shutdown_notification(void *arg)
}
#endif
static void fill_fsps_acoustic_params(FSP_M_CONFIG *m_cfg,
const struct soc_intel_pantherlake_config *config)
static void fill_fspm_acoustic_params(FSP_M_CONFIG *m_cfg,
const struct soc_intel_pantherlake_config *config)
{
if (!config->enable_acoustic_noise_mitigation)
return;
@ -370,7 +370,6 @@ static void fill_fsps_acoustic_params(FSP_M_CONFIG *m_cfg,
}
}
static void soc_memory_init_params(FSP_M_CONFIG *m_cfg,
const struct soc_intel_pantherlake_config *config)
{
@ -392,7 +391,7 @@ static void soc_memory_init_params(FSP_M_CONFIG *m_cfg,
fill_fspm_trace_params,
fill_fspm_thermal_params,
fill_fspm_vr_config_params,
fill_fsps_acoustic_params,
fill_fspm_acoustic_params,
};
for (size_t i = 0; i < ARRAY_SIZE(fill_fspm_params); i++)