From 3a84c93b5b8645c21d844df101b0f98923df02b5 Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Wed, 24 Sep 2025 13:56:39 -0700 Subject: [PATCH] soc/intel/pantherlake: Correct function naming and code style Commit f3211e9639d1 ("soc/intel/pantherlake: Add support for Acoustic Noise Mitigation UPDs") introduced minor coding convention violations. These are being addressed as follows: - Renames fill_fsps_acoustic_params to fill_fspm_acoustic_params to align with the naming conventions used for other FSP-M configuration functions. - Removes an unnecessary empty line. - Aligns function parameters. Change-Id: I8652c2fee71c8e2742146b5e622633de78c1c17e Signed-off-by: Jeremy Compostella Reviewed-on: https://review.coreboot.org/c/coreboot/+/89332 Reviewed-by: Nicholas Sudsgaard Tested-by: build bot (Jenkins) Reviewed-by: Bora Guvendik Reviewed-by: Subrata Banik Reviewed-by: Pranava Y N --- src/soc/intel/pantherlake/romstage/fsp_params.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/soc/intel/pantherlake/romstage/fsp_params.c b/src/soc/intel/pantherlake/romstage/fsp_params.c index ba6c110f2e..30b4eac48a 100644 --- a/src/soc/intel/pantherlake/romstage/fsp_params.c +++ b/src/soc/intel/pantherlake/romstage/fsp_params.c @@ -356,8 +356,8 @@ void platform_display_early_shutdown_notification(void *arg) } #endif -static void fill_fsps_acoustic_params(FSP_M_CONFIG *m_cfg, - const struct soc_intel_pantherlake_config *config) +static void fill_fspm_acoustic_params(FSP_M_CONFIG *m_cfg, + const struct soc_intel_pantherlake_config *config) { if (!config->enable_acoustic_noise_mitigation) return; @@ -370,7 +370,6 @@ static void fill_fsps_acoustic_params(FSP_M_CONFIG *m_cfg, } } - static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_pantherlake_config *config) { @@ -392,7 +391,7 @@ static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, fill_fspm_trace_params, fill_fspm_thermal_params, fill_fspm_vr_config_params, - fill_fsps_acoustic_params, + fill_fspm_acoustic_params, }; for (size_t i = 0; i < ARRAY_SIZE(fill_fspm_params); i++)