This patch modifies the get_lid_switch() function to allow faking the lid switch state when the GBB_FLAG_DISABLE_LID_SHUTDOWN Kconfig option is enabled. When GBB_FLAG_DISABLE_LID_SHUTDOWN is enabled, the function will always return 1 (lid open), bypassing the actual lid switch state retrieval from the Embedded Controller (EC). This functionality is specifically designed to facilitate factory processes, such as netboot image downloads, where devices need to remain operational regardless of the lid's closed state. This prevents intended shutdowns triggered by a closed lid during manufacturing and testing. By setting GBB_FLAG_DISABLE_LID_SHUTDOWN, we override the actual lid status with a simulated LID status is open, which is a prerequisite for display initialization. w/o this patch: ``` [ALERT] Graphics hand-off block not found ... [INFO ] NAME | PORT | POLARITY | VALUE [INFO ] lid | undefined | high | low ``` w/ this patch: ``` [INFO ] NAME | PORT | POLARITY | VALUE [INFO ] lid | undefined | high | high ... [INFO ] framebuffer_info: bytes_per_line: 7680, bits_per_pixel: 32 [INFO ] x_res x y_res: 1920 x 1200, size: 9216000 at 0xd0000000 ``` BUG=b:333982806 TEST=Verified lid switch behavior with and without `GBB_FLAG_DISABLE_LID_SHUTDOWN` enabled. Change-Id: I89d506ab50b421b93be13b0e5e36a7ef1247e2b9 Signed-off-by: Subrata Banik <subratabanik@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86807 Reviewed-by: Jayvik Desai <jayvik@google.com> Reviewed-by: Caveh Jalali <caveh@chromium.org> Reviewed-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> |
||
|---|---|---|
| .. | ||
| 51nb/npce985la0dx | ||
| acpi | ||
| apple/acpi | ||
| clevo/it5570e | ||
| compal/ene932 | ||
| dasharo/ec | ||
| dell/mec5035 | ||
| hp/kbc1126 | ||
| intel | ||
| kontron | ||
| lenovo | ||
| purism | ||
| quanta | ||
| roda/it8518 | ||
| smsc/mec1308 | ||
| starlabs/merlin | ||
| system76/ec | ||
| ec.h | ||