erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ec/acpi/ec.c: Promote timeout messages to errors

Browse source 
A timeout when attempting to read/write to an EC should be treated as
an error, as it could potentially cause unwanted or unexpected behavior
from the device.

Change-Id: I60be6191dcd8ff576fa525f08720b6ea2d0a7454
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85229
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
This commit is contained in:
Nicholas Sudsgaard 2024-11-21 09:24:16 +00:00 • committed by Matt DeVillier
commit b5704497fa
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/ec/acpi/ec.c
View file

@ -45,7 +45,7 @@ int send_ec_command(u8 command)
int send_ec_command_timeout(u8 command, int timeout_us)
{
if (!ec_ready_send(timeout_us)) {
printk(BIOS_DEBUG, "Timeout while sending command 0x%02x to EC!\n",
printk(BIOS_ERR, "Timeout while sending command 0x%02x to EC!\n",
command);
return -1;
}
@ -63,7 +63,7 @@ int send_ec_data(u8 data)
int send_ec_data_timeout(u8 data, int timeout_us)
{
if (!ec_ready_send(timeout_us)) {
printk(BIOS_DEBUG, "Timeout while sending data 0x%02x to EC!\n",
printk(BIOS_ERR, "Timeout while sending data 0x%02x to EC!\n",
data);
return -1;
}
@ -83,7 +83,7 @@ int recv_ec_data_timeout(int timeout_us)
u8 data;
if (!ec_ready_recv(timeout_us)) {
printk(BIOS_DEBUG, "Timeout while receiving data from EC!\n");
printk(BIOS_ERR, "Timeout while receiving data from EC!\n");
return -1;
}