coreboot/payloads/libpayload/drivers/serial
Yogesh Lal 61528884ad libpayload: ipq808x: stale interrupt shall not be cleared unconditionally
The serial driver hangs in cases when FIFO has more than single word to be
processed. Easiest way to reproduce is to paste a string of greater than 4
characters in cli.

Clearing the RXSTALE interrupt without draining all the characters from FIFO
leads to the issue as the driver is dependent on msm_boot_uart_dm_read
function to reinitialize for next transfer.

Logically the driver is organized in such a manner that next transfer never
gets initiated till rx_data_read < total_rx_data. Clearing the RXSTALE without
consideration of total number of characters (or words) unprocessed makes the
msm_boot_uart_dm_read to return on the first if conditional. Thus the driver is
stuck forever.

A quick fix is to avoid clearing the stale interrupt. Reset is handled whenever
a new transfer is initialized in msm_boot_uart_dm_init_rx_transfer.

BUG=chrome-os-partner:29542
TEST=manual
	-Paste a string greater than 4 characters in cli.

Change-Id: I016afb01a77cd14764f0176f6bf144fb29796c2f
Signed-off-by: Yogesh Lal <ylal@codeaurora.org>
Reviewed-on: https://chromium-review.googlesource.com/209512
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
2014-07-26 02:43:49 +00:00
..
8250.c libpayload: console: Allow output drivers to print whole strings at once 2014-04-30 10:00:35 +00:00
ipq806x.c libpayload: ipq808x: stale interrupt shall not be cleared unconditionally 2014-07-26 02:43:49 +00:00
rk_serial.c libpayload: Support board veyron 2014-07-02 00:47:36 +00:00
s5p.c libpayload: serial: Move the depthcharge serial drivers into libpayload. 2014-04-12 05:53:55 +00:00
tegra.c libpayload: Fix baseaddr access in serial/tegra.c 2014-06-20 11:11:11 +00:00