erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/src/soc/intel
History
Lee Leahy 7ecc317828 UPSTREAM: soc/intel/quark: Fix legacy GPIO reads 
Add missing break to LEG_GPIO_REGS case to return the correct value for
legacy GPIO reads.  Fixes coverity issue CID 1357460.

Found by Coverity, Fixes:
* CID 1357460 (#1 of 1): Unused value (UNUSED_VALUE)
  returned_value: Assigning value from reg_legacy_gpio_read(step->reg)
  to value here, but that stored value is overwritten before it can be
  used.

  value_overwrite: Overwriting previous write to value with value from
  reg_pcie_afe_read(step->reg).

TEST=Build and run on Galileo Gen2.

BUG=None
BRANCH=None

Signed-off-by: Lee Leahy <leroy.p.leahy@intel.com>
Reviewed-on: https://review.coreboot.org/15732
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth@google.com>

Change-Id: I6c52e8801a32f510ac94276fe0c097850cbfde57
Reviewed-on: https://chromium-review.googlesource.com/362135
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
2016-07-21 11:21:56 -07:00
..
apollolake UPSTREAM: drivers/intel/fsp2_0: Split reset handling logic 2016-07-19 18:33:31 -07:00
baytrail UPSTREAM: soc/intel/baytrail: use common Intel ACPI hardware definitions 2016-07-15 08:39:59 -07:00
braswell UPSTREAM: soc/intel/braswell: use common Intel ACPI hardware definitions 2016-07-15 08:40:01 -07:00
broadwell UPSTREAM: soc/intel/broadwell: use common Intel ACPI hardware definitions 2016-07-15 08:40:08 -07:00
common UPSTREAM: soc/intel/common: Add reset_prepare() for common reset 2016-07-19 18:33:24 -07:00
fsp_baytrail UPSTREAM: soc/intel/fsp_baytrail: use common Intel ACPI hardware definitions 2016-07-15 08:40:10 -07:00
fsp_broadwell_de UPSTREAM: soc/intel/fsp_broadwell_de: use common Intel ACPI hardware definitions 2016-07-15 08:40:06 -07:00
quark UPSTREAM: soc/intel/quark: Fix legacy GPIO reads 2016-07-21 11:21:56 -07:00
sch UPSTREAM: intel/sch: Merge northbridge and southbridge in src/soc 2016-05-20 17:08:20 -07:00
skylake UPSTREAM: soc/intel/skylake: provide poweroff() implementation 2016-07-15 16:50:31 -07:00