erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mainboard/google/fatcat: Drop logo_valignment selection

Browse source 
This commit removes the explicit `logo_valignment` setting from the
`common_soc_config` for all Fatcat mainboard variants (fatcat, felino,
francka, and kinmen).

The default vertical alignment for the splash screen logo is
`FW_SPLASH_VALIGNMENT_CENTER`, which is the desired behavior for these
boards (in presence of footer logo).

BUG=b:423591644
TEST=Able to show OEM splash screen on google/fatcat at center of the
screen.

Change-Id: I3a9e86a928cdd76f13157eff2a29f209167613a8
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/88031
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
This commit is contained in:
Subrata Banik 2025-06-10 19:52:06 +05:30
commit ef051256dc
4 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
View file

@ -128,7 +128,6 @@ chip soc/intel/pantherlake
#| I2C5 | Touchpad |
#+-------------------+---------------------------+
register "common_soc_config" = "{
.logo_valignment = FW_SPLASH_VALIGNMENT_MIDDLE,
.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
.i2c[1] = {
.speed = I2C_SPEED_FAST,

1
src/mainboard/google/fatcat/variants/felino/overridetree.cb
View file

@ -102,7 +102,6 @@ chip soc/intel/pantherlake
#| I2C4 | CLICK PAD |
#+-------------------+---------------------------+
register "common_soc_config" = "{
.logo_valignment = FW_SPLASH_VALIGNMENT_MIDDLE,
.i2c[1] = {
.early_init=1,
.speed = I2C_SPEED_FAST,

1
src/mainboard/google/fatcat/variants/francka/overridetree.cb
View file

@ -78,7 +78,6 @@ chip soc/intel/pantherlake
#| I2C4 | Touchscreen, Touchpad |
#+-------------------+---------------------------+
register "common_soc_config" = "{
.logo_valignment = FW_SPLASH_VALIGNMENT_MIDDLE,
.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
.i2c[1] = {
.early_init = 1,

1
src/mainboard/google/fatcat/variants/kinmen/overridetree.cb
View file

@ -65,7 +65,6 @@ chip soc/intel/pantherlake
#| I2C5 | Touchscreen |
#+-------------------+---------------------------+
register "common_soc_config" = "{
.logo_valignment = FW_SPLASH_VALIGNMENT_MIDDLE,
.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
.i2c[3] = {
.early_init = 1,