From ef051256dc2825cb151b2d4b18223f28fc5942b6 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Tue, 10 Jun 2025 19:52:06 +0530 Subject: [PATCH] mainboard/google/fatcat: Drop logo_valignment selection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit removes the explicit `logo_valignment` setting from the `common_soc_config` for all Fatcat mainboard variants (fatcat, felino, francka, and kinmen). The default vertical alignment for the splash screen logo is `FW_SPLASH_VALIGNMENT_CENTER`, which is the desired behavior for these boards (in presence of footer logo). BUG=b:423591644 TEST=Able to show OEM splash screen on google/fatcat at center of the screen. Change-Id: I3a9e86a928cdd76f13157eff2a29f209167613a8 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/88031 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal Reviewed-by: Jérémy Compostella --- src/mainboard/google/fatcat/variants/fatcat/overridetree.cb | 1 - src/mainboard/google/fatcat/variants/felino/overridetree.cb | 1 - src/mainboard/google/fatcat/variants/francka/overridetree.cb | 1 - src/mainboard/google/fatcat/variants/kinmen/overridetree.cb | 1 - 4 files changed, 4 deletions(-) diff --git a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb index 858205902d..565aad6f98 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb @@ -128,7 +128,6 @@ chip soc/intel/pantherlake #| I2C5 | Touchpad | #+-------------------+---------------------------+ register "common_soc_config" = "{ - .logo_valignment = FW_SPLASH_VALIGNMENT_MIDDLE, .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .i2c[1] = { .speed = I2C_SPEED_FAST, diff --git a/src/mainboard/google/fatcat/variants/felino/overridetree.cb b/src/mainboard/google/fatcat/variants/felino/overridetree.cb index ee19c1ed5b..9184f1d62a 100644 --- a/src/mainboard/google/fatcat/variants/felino/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/felino/overridetree.cb @@ -102,7 +102,6 @@ chip soc/intel/pantherlake #| I2C4 | CLICK PAD | #+-------------------+---------------------------+ register "common_soc_config" = "{ - .logo_valignment = FW_SPLASH_VALIGNMENT_MIDDLE, .i2c[1] = { .early_init=1, .speed = I2C_SPEED_FAST, diff --git a/src/mainboard/google/fatcat/variants/francka/overridetree.cb b/src/mainboard/google/fatcat/variants/francka/overridetree.cb index 983cb91487..bbf6654068 100644 --- a/src/mainboard/google/fatcat/variants/francka/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/francka/overridetree.cb @@ -78,7 +78,6 @@ chip soc/intel/pantherlake #| I2C4 | Touchscreen, Touchpad | #+-------------------+---------------------------+ register "common_soc_config" = "{ - .logo_valignment = FW_SPLASH_VALIGNMENT_MIDDLE, .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .i2c[1] = { .early_init = 1, diff --git a/src/mainboard/google/fatcat/variants/kinmen/overridetree.cb b/src/mainboard/google/fatcat/variants/kinmen/overridetree.cb index 6f2b379ba0..8299b42f97 100644 --- a/src/mainboard/google/fatcat/variants/kinmen/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/kinmen/overridetree.cb @@ -65,7 +65,6 @@ chip soc/intel/pantherlake #| I2C5 | Touchscreen | #+-------------------+---------------------------+ register "common_soc_config" = "{ - .logo_valignment = FW_SPLASH_VALIGNMENT_MIDDLE, .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .i2c[3] = { .early_init = 1,