erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/cmn/blk/cnvi: Add descriptive comments for PRRS and RSTT

Browse source 
Enhance the readability and maintainability of the code by adding
detailed comments for the ACPI names "PRRS" and "RSTT" in the
`cnvw_fill_ssdt` function. These comments clarify the possible status
values for "PRRS" and the reset types for "RSTT", aiding developers in
understanding the function's logic and expected behavior.

Change-Id: I94486476cf2f95b8e1744ee369a9d9d6c734bba8
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/88086
Reviewed-by: Wonkyu Kim <wonkyu.kim@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Jeremy Compostella 2025-06-12 10:19:15 -07:00 • committed by Sean Rhodes
commit ea8a3e685f
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/soc/intel/common/block/cnvi/cnvi.c
View file

@ -93,11 +93,20 @@ static void cnvw_fill_ssdt(const struct device *dev)
/*
* Name (PRRS, Zero)
* Last _PRR Status
* 0: Non-Platform-Level Device Reset (PLDR) executed [Default]
* 1: Core PLDR Completed successfully
* 2: Product PLDR Completed successfully
* 3: Previous PLDR Not Completed
* 4: Product PLDR timeout
*/
acpigen_write_name_integer("PRRS", 0);
/*
* Name (RSTT, Zero)
* Reset Type
* 0: Core Reset
* 1: Product Reset
*/
acpigen_write_name_integer("RSTT", 0);