erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

qualcomm/common: Remove dead code

Browse source 
fb_off is set to zero, meaning the else branch is never called.

Coverity-ID: 1469336
Fixes: 3b4c45efa2 ("sc7180: Add display hardware pipe line initialization")
Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85778
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Jonathon Hall <jonathon.hall@puri.sm>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Ariel Otilibili 2024-12-26 16:02:38 +01:00 • committed by Felix Singer
commit e06e33416e
1 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/soc/qualcomm/common/display/mdss.c
View file

@ -21,13 +21,8 @@ static void mdss_source_pipe_config(struct edid *edid)
out_size = img_size;
stride = (edid->mode.ha * edid->framebuffer_bits_per_pixel/8);
if (!fb_off) { /* left */
dst_xy = (edid->mode.vborder << 16) | edid->mode.hborder;
src_xy = dst_xy;
} else { /* right */
dst_xy = (edid->mode.vborder << 16);
src_xy = (edid->mode.vborder << 16) | fb_off;
}
dst_xy = (edid->mode.vborder << 16) | edid->mode.hborder;
src_xy = dst_xy;
printk(BIOS_INFO, "%s: src=%x fb_off=%x src_xy=%x dst_xy=%x\n",
__func__, out_size, fb_off, src_xy, dst_xy);