From e06e33416e7affde38d295a03a3a11320ed3b884 Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Thu, 26 Dec 2024 16:02:38 +0100 Subject: [PATCH] qualcomm/common: Remove dead code fb_off is set to zero, meaning the else branch is never called. Coverity-ID: 1469336 Fixes: 3b4c45efa2 ("sc7180: Add display hardware pipe line initialization") Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e Signed-off-by: Ariel Otilibili Reviewed-on: https://review.coreboot.org/c/coreboot/+/85778 Reviewed-by: Yidi Lin Reviewed-by: Elyes Haouas Reviewed-by: Jonathon Hall Reviewed-by: Felix Singer Reviewed-by: Varshit Pandya Tested-by: build bot (Jenkins) --- src/soc/qualcomm/common/display/mdss.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/soc/qualcomm/common/display/mdss.c b/src/soc/qualcomm/common/display/mdss.c index a1c13ee9da..0a7a29d4ca 100644 --- a/src/soc/qualcomm/common/display/mdss.c +++ b/src/soc/qualcomm/common/display/mdss.c @@ -21,13 +21,8 @@ static void mdss_source_pipe_config(struct edid *edid) out_size = img_size; stride = (edid->mode.ha * edid->framebuffer_bits_per_pixel/8); - if (!fb_off) { /* left */ - dst_xy = (edid->mode.vborder << 16) | edid->mode.hborder; - src_xy = dst_xy; - } else { /* right */ - dst_xy = (edid->mode.vborder << 16); - src_xy = (edid->mode.vborder << 16) | fb_off; - } + dst_xy = (edid->mode.vborder << 16) | edid->mode.hborder; + src_xy = dst_xy; printk(BIOS_INFO, "%s: src=%x fb_off=%x src_xy=%x dst_xy=%x\n", __func__, out_size, fb_off, src_xy, dst_xy);