erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/common/block: Fixup itss_get_on_chip_dev_pirq

Browse source 
pcr_read16(PID_ITSS, itss_soc_get_on_chip_dev_pir(dev)) returns
the register content and should not be compared with
PCI_ITSS_PIR(0) which is an address offset. By now, we assume the
returned PIR is always effective and usable.

Change-Id: I2e61629bdcdea33f260bfbc47f22d40d9a869c6b
Signed-off-by: Shuo Liu <shuo.liu@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85284
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Reviewed-by: <yuchi.chen@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Shuo Liu 2024-11-25 20:01:43 +08:00 • committed by Lean Sheng Tan
commit dfdb210e26
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/soc/intel/common/block/itss/itss.c
View file

@ -142,8 +142,6 @@ enum pirq itss_get_on_chip_dev_pirq(const struct device *dev, enum pci_pin pin)
return PIRQ_INVALID;
uint16_t pir = pcr_read16(PID_ITSS, itss_soc_get_on_chip_dev_pir(dev));
if (pir < PCI_ITSS_PIR(0))
return PIRQ_INVALID;
/* The lower 3 bits of every 4 bits indicates which PIRQ is connect to INT. */
unsigned int pir_shift = (pin - PCI_INT_A) * 4;