From dfdb210e2633043bbd46582de023d59370cf11bf Mon Sep 17 00:00:00 2001 From: Shuo Liu Date: Mon, 25 Nov 2024 20:01:43 +0800 Subject: [PATCH] soc/intel/common/block: Fixup itss_get_on_chip_dev_pirq pcr_read16(PID_ITSS, itss_soc_get_on_chip_dev_pir(dev)) returns the register content and should not be compared with PCI_ITSS_PIR(0) which is an address offset. By now, we assume the returned PIR is always effective and usable. Change-Id: I2e61629bdcdea33f260bfbc47f22d40d9a869c6b Signed-off-by: Shuo Liu Reviewed-on: https://review.coreboot.org/c/coreboot/+/85284 Reviewed-by: Lean Sheng Tan Reviewed-by: Tested-by: build bot (Jenkins) --- src/soc/intel/common/block/itss/itss.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/soc/intel/common/block/itss/itss.c b/src/soc/intel/common/block/itss/itss.c index e2ff3ef602..8409e966c5 100644 --- a/src/soc/intel/common/block/itss/itss.c +++ b/src/soc/intel/common/block/itss/itss.c @@ -142,8 +142,6 @@ enum pirq itss_get_on_chip_dev_pirq(const struct device *dev, enum pci_pin pin) return PIRQ_INVALID; uint16_t pir = pcr_read16(PID_ITSS, itss_soc_get_on_chip_dev_pir(dev)); - if (pir < PCI_ITSS_PIR(0)) - return PIRQ_INVALID; /* The lower 3 bits of every 4 bits indicates which PIRQ is connect to INT. */ unsigned int pir_shift = (pin - PCI_INT_A) * 4;