erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/pantherlake: Let common code set PL1 to TDP

Browse source 
Update PL1 override values from a fixed value to zero, indicating that
the platform should use the default TDP value. This change allows the
common code to dynamically set PL1 according to the specific TDP SKU,
improving flexibility and ensuring correct power limit configuration
across different hardware variants.

Previously, PL1 was hardcoded to 15 for some SKUs, which could lead to
instabilities for SKUs with different TDP requirements.

TEST=No instability was observed on certain Fatcat SKUs.

Change-Id: Ibfb6b52aa15ad66740abc39f6f869dfa5e90de3c
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/89934
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Guvendik, Bora <bora.guvendik@intel.com>
Reviewed-by: Ryu, Jamie M <jamie.m.ryu@intel.com>
Reviewed-by: Kim, Wonkyu <wonkyu.kim@intel.com>
This commit is contained in:
Jeremy Compostella 2025-11-06 11:28:09 -08:00 • committed by Matt DeVillier
commit dc68f5b265
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/soc/intel/pantherlake/chipset_ptl.cb
View file

@ -3,7 +3,7 @@ chip soc/intel/pantherlake
device cpu_cluster 0 on end
register "power_limits_config[PTL_CORE_1]" = "{
.tdp_pl1_override = 15,
.tdp_pl1_override = 0, /* Use TDP */
.tdp_pl2_override = 55,
.tdp_pl4 = 163,
.tdp_pl4_fastvmode = 150,
@ -24,7 +24,7 @@ chip soc/intel/pantherlake
}"
register "power_limits_config[PTL_CORE_2]" = "{
.tdp_pl1_override = 15,
.tdp_pl1_override = 0, /* Use TDP */
.tdp_pl2_override = 55,
.tdp_pl4 = 163,
.tdp_pl4_fastvmode = 150,
@ -37,7 +37,7 @@ chip soc/intel/pantherlake
}"
register "power_limits_config[PTL_CORE_3]" = "{
.tdp_pl1_override = 25,
.tdp_pl1_override = 0, /* Use TDP */
.tdp_pl2_override = 65,
.tdp_pl4 = 175,
.tdp_pl4_fastvmode = 160,
@ -58,7 +58,7 @@ chip soc/intel/pantherlake
}"
register "power_limits_config[PTL_CORE_4]" = "{
.tdp_pl1_override = 25,
.tdp_pl1_override = 0, /* Use TDP */
.tdp_pl2_override = 65,
.tdp_pl4 = 160,
.tdp_pl4_fastvmode = 140