soc/intel/common/reset: Mark do_low_battery_poweroff with __noreturn
In the low battery poweroff scenario, the platform should halt after issuing the poweroff command. This ensures that no further code execution occurs, preventing potential issues. Additionally, the do_low_battery_poweroff() function is marked with __noreturn to indicate that it does not return. This is appropriate because the platform will either power off or halt. TEST=Able to compile google/fatcat. Change-Id: Ieb77645283360b5731ca48b94551712b99109a1c Signed-off-by: Subrata Banik <subratabanik@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86578 Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com> Reviewed-by: Kapil Porwal <kapilporwal@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jayvik Desai <jayvik@google.com>
This commit is contained in:
parent
a8139c0b87
commit
d9da262829
2 changed files with 2 additions and 1 deletions
|
|
@ -32,4 +32,5 @@ void do_low_battery_poweroff(void)
|
|||
}
|
||||
|
||||
poweroff();
|
||||
halt();
|
||||
}
|
||||
|
|
|
|||
|
|
@ -30,6 +30,6 @@ efi_return_status_t fsp_get_pch_reset_status(void);
|
|||
*
|
||||
* Call this function to power off the platform if the battery level is critically low.
|
||||
*/
|
||||
void do_low_battery_poweroff(void);
|
||||
__noreturn void do_low_battery_poweroff(void);
|
||||
|
||||
#endif /* _INTEL_COMMON_RESET_H_ */
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue