erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

commonlib: Refactor CSE sync eventLog

Browse source 
This patch enhances the readability of the CSE sync event
ELOG_TYPE_FW_CSE_SYNC by updating the event naming from "early and late
bootstage" to "pre and post memory."

BUG=b:379585294
TEST=boot verified on google/rex0 and google/rex64
without change:
```
rex-rev3 ~ # elogtool list
rex64-rev3 ~ # /media/usb/elogtool list
3 | 2024-01-01 22:25:59-0800 | Firmware CSE sync | Late CSE Sync
```
with change:
```
rex64-rev3 ~ # elogtool list
3 | 2024-12-17 02:22:36-0800 | Firmware CSE sync | Post RAM CSE Sync
```

Change-Id: Ia5db3ffb43b2ceac821de72ef9e88ed62e617d41
Signed-off-by: Dinesh Gehlot <digehlot@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85622
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Dinesh Gehlot 2024-12-17 17:03:56 +05:30 • committed by Subrata Banik
commit d90b1322ab
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/commonlib/bsd/include/commonlib/bsd/elog.h
View file

@ -385,8 +385,8 @@ struct elog_event_extended_event {
* Events related to CSE sync
*/
#define ELOG_TYPE_FW_CSE_SYNC 0xbd
#define ELOG_FW_EARLY_CSE_SYNC 0x0
#define ELOG_FW_LATE_CSE_SYNC 0x1
#define ELOG_FW_PRE_RAM_CSE_SYNC 0x0
#define ELOG_FW_POST_RAM_CSE_SYNC 0x1
#define ELOG_FW_CSE_SYNC_AT_PAYLOAD 0x2
/* Only the 7-LSB are used for size */

4
src/soc/intel/common/block/cse/cse_lite.c
View file

@ -806,8 +806,8 @@ static enum cb_err cse_write_rw_region(const struct region_device *target_rdev,
return CB_ERR;
printk(BIOS_INFO, "cse_lite: CSE RW Update Successful\n");
elog_add_event_byte(ELOG_TYPE_FW_CSE_SYNC, ENV_RAMSTAGE ? ELOG_FW_LATE_CSE_SYNC :
ELOG_FW_EARLY_CSE_SYNC);
elog_add_event_byte(ELOG_TYPE_FW_CSE_SYNC, ENV_RAMSTAGE ? ELOG_FW_POST_RAM_CSE_SYNC :
ELOG_FW_PRE_RAM_CSE_SYNC);
return CB_SUCCESS;
}

4
util/cbfstool/eventlog.c
View file

@ -485,8 +485,8 @@ static int eventlog_print_data(const struct event_header *event)
};
static const struct valstr cse_sync_path_types[] = {
{ELOG_FW_EARLY_CSE_SYNC, "Early CSE Sync"},
{ELOG_FW_LATE_CSE_SYNC, "Late CSE Sync"},
{ELOG_FW_PRE_RAM_CSE_SYNC, "Pre-RAM CSE Sync"},
{ELOG_FW_POST_RAM_CSE_SYNC, "Post-RAM CSE Sync"},
{ELOG_FW_CSE_SYNC_AT_PAYLOAD, "CSE Sync at Payload"},
{0, NULL},
};