erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

acpi/dsdt_top.asl: Move RBUF out of the _CRS method

Browse source 
This solves the remark:
```
dsdt.asl     28:    Name (RBUF, ResourceTemplate ()
Remark   2173 -             ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.PERC._CRS)
```

Change-Id: Ifff2678e351cf6d92a7fba5d3cf64413e15393c0
Signed-off-by: Evie (Ivi) Ballou <iviballou@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91037
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Alicja Michalska <ahplka19@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
This commit is contained in:
Evie (Ivi) Ballou 2026-02-01 03:08:06 +02:00 • committed by Matt DeVillier
commit d23bd33161
1 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/acpi/dsdt_top.asl
View file

@ -57,22 +57,22 @@ Scope(\_SB) {
Device (PERC) // PCI ECAM Resource Consumption
{
Name (_HID, EisaId("PNP0C02"))
Name (RBUF, ResourceTemplate ()
{
QWordMemory (ResourceConsumer, PosDecode, MinFixed, MaxFixed,
NonCacheable, ReadWrite,
0x0000000000000000, // Granularity
0x0000000000000000, // _MIN
0x0000000000000001, // _MAX
0x0000000000000000, // Translation
0x0000000000000002, // _Len
,, _Y00, AddressRangeMemory, TypeStatic)
})
Method (_CRS, 0, Serialized)
{
Name (RBUF, ResourceTemplate ()
{
QWordMemory (ResourceConsumer, PosDecode, MinFixed, MaxFixed,
NonCacheable, ReadWrite,
0x0000000000000000, // Granularity
0x0000000000000000, // _MIN
0x0000000000000001, // _MAX
0x0000000000000000, // Translation
0x0000000000000002, // _Len
,, _Y00, AddressRangeMemory, TypeStatic)
})
CreateQWordField (RBUF, \_SB.PERC._CRS._Y00._MIN, MIN1)
CreateQWordField (RBUF, \_SB.PERC._CRS._Y00._MAX, MAX1)
CreateQWordField (RBUF, \_SB.PERC._CRS._Y00._LEN, LEN1)
CreateQWordField (RBUF, \_SB.PERC._Y00._MIN, MIN1)
CreateQWordField (RBUF, \_SB.PERC._Y00._MAX, MAX1)
CreateQWordField (RBUF, \_SB.PERC._Y00._LEN, LEN1)
MIN1 = CONFIG_ECAM_MMCONF_BASE_ADDRESS
MAX1 = (MIN1 + CONFIG_ECAM_MMCONF_LENGTH -1)
LEN1 = CONFIG_ECAM_MMCONF_LENGTH