erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drv/intel/mipi_camera: Verify SSDB only for camera sensors

Browse source 
The MIPI camera driver currently validates SSDB parameters for all
devices using the driver. However, some devices (VCM/NVM) does not have
these parameters configured.

Wrap the SSDB verification logic in a check for
`INTEL_ACPI_CAMERA_SENSOR`. This prevents the driver from throwing
"Parameters not set" errors and failing to create ACPI devices for
non-sensor devices.

BUG=b:474223827
TEST=Build and boot fatcat, verify that MIPI initialization no longer
fails for non-sensor MIPI devices while still enforcing validation for
actual camera sensors.

Change-Id: I34ef416cdc9fa35fdca21e9fecaa8d7fc2914338
Signed-off-by: Pranava Y N <pranavayn@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90697
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Pranava Y N 2026-01-08 13:15:23 +05:30 • committed by Matt DeVillier
commit ceaa41c9e4
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/drivers/intel/mipi_camera/camera.c
View file

@ -1219,10 +1219,19 @@ static struct device_operations camera_ops = {
static void camera_enable(struct device *dev)
{
//Validate Camera Parameters
/* Validate Camera Parameters */
struct drivers_intel_mipi_camera_config *config = dev->chip_info;
bool params_error = false;
/*
* Non-sensor devices (like an aggregator) don't need
* SSDB validation, just assign ops and return.
*/
if (config->device_type != INTEL_ACPI_CAMERA_SENSOR) {
dev->ops = &camera_ops;
return;
}
if (!config->ssdb.lanes_used) {
printk(BIOS_ERR, "MIPI camera: SSDB lanes_used not set\n");
params_error = true;