From ceaa41c9e47cc43278af2f0c6ba7612c204f5de1 Mon Sep 17 00:00:00 2001 From: Pranava Y N Date: Thu, 8 Jan 2026 13:15:23 +0530 Subject: [PATCH] drv/intel/mipi_camera: Verify SSDB only for camera sensors The MIPI camera driver currently validates SSDB parameters for all devices using the driver. However, some devices (VCM/NVM) does not have these parameters configured. Wrap the SSDB verification logic in a check for `INTEL_ACPI_CAMERA_SENSOR`. This prevents the driver from throwing "Parameters not set" errors and failing to create ACPI devices for non-sensor devices. BUG=b:474223827 TEST=Build and boot fatcat, verify that MIPI initialization no longer fails for non-sensor MIPI devices while still enforcing validation for actual camera sensors. Change-Id: I34ef416cdc9fa35fdca21e9fecaa8d7fc2914338 Signed-off-by: Pranava Y N Reviewed-on: https://review.coreboot.org/c/coreboot/+/90697 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/drivers/intel/mipi_camera/camera.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index 1b2fc692d8..79c0616ccf 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -1219,10 +1219,19 @@ static struct device_operations camera_ops = { static void camera_enable(struct device *dev) { - //Validate Camera Parameters + /* Validate Camera Parameters */ struct drivers_intel_mipi_camera_config *config = dev->chip_info; bool params_error = false; + /* + * Non-sensor devices (like an aggregator) don't need + * SSDB validation, just assign ops and return. + */ + if (config->device_type != INTEL_ACPI_CAMERA_SENSOR) { + dev->ops = &camera_ops; + return; + } + if (!config->ssdb.lanes_used) { printk(BIOS_ERR, "MIPI camera: SSDB lanes_used not set\n"); params_error = true;