erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/brox: Update Auxiliary Firmware Version check

Browse source 
Currently check_auxfw_ver_mismatch() expects the hash file to contain
only auxiliary firmware version and hence strictly checks for the size
of the auxiliary firmware version (3 bytes).

However, in some cases the hash file might contain other information
such as config_name.bin name which increases the hash file size.

Accommodate this scenario by checking the hash file size greater than
or equal to auxiliary firmware version size.

BUG=b:445606386
TEST=Build BIOS image with hash size of 3 and 11. Ensure that the
hints are provided correctly and 2 redundant resets are filtered out.

Change-Id: I287079cfc3cfbc75575ecde0603b98c57b42aa24
Signed-off-by: Tony Huang <tony-huang@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/89219
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
This commit is contained in:
Tony Huang 2025-09-17 16:10:42 +08:00 • committed by Matt DeVillier
commit cbd1529126
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mainboard/google/brox/variants/baseboard/brox/romstage.c
View file

@ -36,7 +36,7 @@ static bool check_auxfw_ver_mismatch(void)
/* find bundled fw hash */
new_ver = cbfs_map(fwver_fname, &new_ver_size);
if (new_ver == NULL || new_ver_size != FWVER_SIZE)
if (new_ver == NULL || new_ver_size < FWVER_SIZE)
return mismatch;
/*