From cbd152912622879d7543954519b68766fad6cdfe Mon Sep 17 00:00:00 2001 From: Tony Huang Date: Wed, 17 Sep 2025 16:10:42 +0800 Subject: [PATCH] mb/google/brox: Update Auxiliary Firmware Version check Currently check_auxfw_ver_mismatch() expects the hash file to contain only auxiliary firmware version and hence strictly checks for the size of the auxiliary firmware version (3 bytes). However, in some cases the hash file might contain other information such as config_name.bin name which increases the hash file size. Accommodate this scenario by checking the hash file size greater than or equal to auxiliary firmware version size. BUG=b:445606386 TEST=Build BIOS image with hash size of 3 and 11. Ensure that the hints are provided correctly and 2 redundant resets are filtered out. Change-Id: I287079cfc3cfbc75575ecde0603b98c57b42aa24 Signed-off-by: Tony Huang Reviewed-on: https://review.coreboot.org/c/coreboot/+/89219 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian --- src/mainboard/google/brox/variants/baseboard/brox/romstage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/brox/variants/baseboard/brox/romstage.c b/src/mainboard/google/brox/variants/baseboard/brox/romstage.c index ce402af933..92fd56692d 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/romstage.c +++ b/src/mainboard/google/brox/variants/baseboard/brox/romstage.c @@ -36,7 +36,7 @@ static bool check_auxfw_ver_mismatch(void) /* find bundled fw hash */ new_ver = cbfs_map(fwver_fname, &new_ver_size); - if (new_ver == NULL || new_ver_size != FWVER_SIZE) + if (new_ver == NULL || new_ver_size < FWVER_SIZE) return mismatch; /*