erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/brox/var/lotso: delete mb_get_channel_disable_mask

Browse source 
We found that the lotso project has already used
variant_is_half_populated. If we continue to use the
mb_get_channel_disable_mask API, it will reduce the memory of each DDR
by half. In reality, we are reducing the number of DDR modules (from 4
to 2), so we should remove mb_get_channel_disable_mask to ensure proper
DIMM identification.

BUG=b:468889066
BRANCH=None
TEST=boot to kernel success, and the log shows that the RAM ID is correct.

Change-Id: Ia7fc4610b3257bc20a871080f52f02e089b8531c
Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91426
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Rui Zhou 2026-02-26 09:28:08 +08:00 • committed by Karthik Ramasubramanian
commit c57b88d74d
2 changed files with 0 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/mainboard/google/brox/Kconfig
View file

@ -81,7 +81,6 @@ config BOARD_GOOGLE_BROX_EC_ISH
config BOARD_GOOGLE_LOTSO
select BOARD_GOOGLE_BASEBOARD_BROX
select CHROMEOS_WIFI_SAR if CHROMEOS
select ENFORCE_MEM_CHANNEL_DISABLE
select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD
select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS

13
src/mainboard/google/brox/variants/lotso/memory.c
View file

@ -99,19 +99,6 @@ bool variant_is_half_populated(void)
return gpio_get(GPP_S0);
}
uint8_t mb_get_channel_disable_mask(void)
{
/*
* GPP_S0 High -> One RAM Chip
* GPP_S0 Low -> Two RAM Chip
* Disable all other channels except first two on each controller
*/
if (gpio_get(GPP_S0))
return (BIT(2) | BIT(3));
return 0;
}
void variant_get_spd_info(struct mem_spd *spd_info)
{
spd_info->topo = MEM_TOPO_MEMORY_DOWN;