From c57b88d74ddd6e7296b60a8e327a2d2c22ac725c Mon Sep 17 00:00:00 2001 From: Rui Zhou Date: Thu, 26 Feb 2026 09:28:08 +0800 Subject: [PATCH] mb/google/brox/var/lotso: delete mb_get_channel_disable_mask We found that the lotso project has already used variant_is_half_populated. If we continue to use the mb_get_channel_disable_mask API, it will reduce the memory of each DDR by half. In reality, we are reducing the number of DDR modules (from 4 to 2), so we should remove mb_get_channel_disable_mask to ensure proper DIMM identification. BUG=b:468889066 BRANCH=None TEST=boot to kernel success, and the log shows that the RAM ID is correct. Change-Id: Ia7fc4610b3257bc20a871080f52f02e089b8531c Signed-off-by: Rui Zhou Reviewed-on: https://review.coreboot.org/c/coreboot/+/91426 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/mainboard/google/brox/Kconfig | 1 - src/mainboard/google/brox/variants/lotso/memory.c | 13 ------------- 2 files changed, 14 deletions(-) diff --git a/src/mainboard/google/brox/Kconfig b/src/mainboard/google/brox/Kconfig index bb4d3746b2..8847f33e72 100644 --- a/src/mainboard/google/brox/Kconfig +++ b/src/mainboard/google/brox/Kconfig @@ -81,7 +81,6 @@ config BOARD_GOOGLE_BROX_EC_ISH config BOARD_GOOGLE_LOTSO select BOARD_GOOGLE_BASEBOARD_BROX select CHROMEOS_WIFI_SAR if CHROMEOS - select ENFORCE_MEM_CHANNEL_DISABLE select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS diff --git a/src/mainboard/google/brox/variants/lotso/memory.c b/src/mainboard/google/brox/variants/lotso/memory.c index 0997707e9f..84b9f4a70d 100644 --- a/src/mainboard/google/brox/variants/lotso/memory.c +++ b/src/mainboard/google/brox/variants/lotso/memory.c @@ -99,19 +99,6 @@ bool variant_is_half_populated(void) return gpio_get(GPP_S0); } -uint8_t mb_get_channel_disable_mask(void) -{ - /* - * GPP_S0 High -> One RAM Chip - * GPP_S0 Low -> Two RAM Chip - * Disable all other channels except first two on each controller - */ - if (gpio_get(GPP_S0)) - return (BIT(2) | BIT(3)); - - return 0; -} - void variant_get_spd_info(struct mem_spd *spd_info) { spd_info->topo = MEM_TOPO_MEMORY_DOWN;