erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

oak: Configure SD card detect pin with a pull-up

Browse source 
SD card detect pins should normally have a pull-up. It seems that for
micro-SD cards this doesn't really matter all that much, but for the
full-size slots we have on some Oak-derivatives (like Hana) it does.

BRANCH=oak
BUG=b:35854317
TEST=Booted Hana, confirmed that card detect no longer seemed stuck-on.
Booted Elm and confirmed that SD card behavior didn't change.

Change-Id: I428ac92efb07f94265673b04e0e0dd452649b9fd
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/452861
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
This commit is contained in:
Julius Werner 2017-03-10 14:25:48 -08:00 • committed by chrome-bot
commit c2781eeef5
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mainboard/google/oak/mainboard.c
View file

@ -256,7 +256,7 @@ static void mainboard_init(device_t dev)
mt6391_gpio_output(MT6391_KP_ROW2, 1);
/* Config SD card detection pin */
gpio_input(PAD_EINT1); /* SD_DET */
gpio_input_pullup(PAD_EINT1); /* SD_DET */
configure_audio();