From b5704497fac854df4036086eee2055d179eeda1c Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Thu, 21 Nov 2024 09:24:16 +0000 Subject: [PATCH] ec/acpi/ec.c: Promote timeout messages to errors A timeout when attempting to read/write to an EC should be treated as an error, as it could potentially cause unwanted or unexpected behavior from the device. Change-Id: I60be6191dcd8ff576fa525f08720b6ea2d0a7454 Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/85229 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Elyes Haouas --- src/ec/acpi/ec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ec/acpi/ec.c b/src/ec/acpi/ec.c index dddfb6baa8..4378b02c98 100644 --- a/src/ec/acpi/ec.c +++ b/src/ec/acpi/ec.c @@ -45,7 +45,7 @@ int send_ec_command(u8 command) int send_ec_command_timeout(u8 command, int timeout_us) { if (!ec_ready_send(timeout_us)) { - printk(BIOS_DEBUG, "Timeout while sending command 0x%02x to EC!\n", + printk(BIOS_ERR, "Timeout while sending command 0x%02x to EC!\n", command); return -1; } @@ -63,7 +63,7 @@ int send_ec_data(u8 data) int send_ec_data_timeout(u8 data, int timeout_us) { if (!ec_ready_send(timeout_us)) { - printk(BIOS_DEBUG, "Timeout while sending data 0x%02x to EC!\n", + printk(BIOS_ERR, "Timeout while sending data 0x%02x to EC!\n", data); return -1; } @@ -83,7 +83,7 @@ int recv_ec_data_timeout(int timeout_us) u8 data; if (!ec_ready_recv(timeout_us)) { - printk(BIOS_DEBUG, "Timeout while receiving data from EC!\n"); + printk(BIOS_ERR, "Timeout while receiving data from EC!\n"); return -1; }