erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/amd: Increase ROM size on boards, incorrectly limited to 16 MB

Browse source 
Since commit bb66d07d41
"soc/amd/common: Always use genoa SPI MMAP driver" the ROM size can be
actually be greater than 16MiB on all AMD platforms without seeing a
boot failure. Since still only 16MiB of the SPI flash are MMAPed,
the FMAP should not be extended, and if so should only contain non x86
firmwares in the upper 16MiB of flash.

Now that common code supports ROM_SIZE greater than 16MiB select the
correct BOARD_ROMSIZE_KB for each mainboard.

Change-Id: Icdce01bddbc4873ba42ceddcda6d9075f5a42914
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86701
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Maximilian Brune <maximilian.brune@9elements.com>
This commit is contained in:
Patrick Rudolph 2025-03-04 09:34:00 +01:00 • committed by Matt DeVillier
commit b50ceba64a
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mainboard/amd/birman/Kconfig
View file

@ -2,7 +2,7 @@
config BOARD_AMD_BIRMAN_COMMON
def_bool n
select BOARD_ROMSIZE_KB_16384 # Birman actually has a 32MiB ROM
select BOARD_ROMSIZE_KB_32768
select EC_ACPI
select SOC_AMD_COMMON_BLOCK_USE_ESPI if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD
select DRIVERS_PCIE_RTD3_DEVICE

2
src/mainboard/amd/birman_plus/Kconfig
View file

@ -2,7 +2,7 @@
config BOARD_AMD_BIRMANPLUS_COMMON
def_bool n
select BOARD_ROMSIZE_KB_16384 # Birman+ actually has a 64MiB ROM
select BOARD_ROMSIZE_KB_65536
select EC_ACPI
select SOC_AMD_COMMON_BLOCK_USE_ESPI if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD
select DRIVERS_PCIE_RTD3_DEVICE

2
src/mainboard/amd/crater/Kconfig
View file

@ -2,7 +2,7 @@
config BOARD_AMD_CRATER_COMMON
def_bool n
select BOARD_ROMSIZE_KB_16384 # Birman actually has a 32MiB ROM
select BOARD_ROMSIZE_KB_32768
select EC_ACPI
select SOC_AMD_COMMON_BLOCK_USE_ESPI if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD
select DRIVERS_PCIE_RTD3_DEVICE

2
src/mainboard/amd/mayan/Kconfig
View file

@ -4,7 +4,7 @@ if BOARD_AMD_MAYAN_PHOENIX
config BOARD_SPECIFIC_OPTIONS
def_bool y
select BOARD_ROMSIZE_KB_16384 # Mayan actually has a 32MiB ROM
select BOARD_ROMSIZE_KB_32768
select EC_ACPI
select SOC_AMD_COMMON_BLOCK_USE_ESPI
select AMD_SOC_CONSOLE_UART