erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drivers/intel/mipi_camera: Extract SSDB definitions into separate header

Browse source 
Move the sensor SSDB struct and enums out of `chip.h` and into a new
`ssdb.h`. This keeps the chip interface header lean while providing a
dedicated spot for the additional SSDB field descriptors coming in
follow-up changes. No functional impact.

Change-Id: Ifb2dddb886f0123b1dfd059400dcacd75174fb6c
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90181
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Matt DeVillier 2025-11-09 16:50:52 -06:00
commit ab4c2fd0e8
2 changed files with 101 additions and 91 deletions
Download patch file Download diff file Expand all files Collapse all files

92
src/drivers/intel/mipi_camera/chip.h
View file

@ -6,6 +6,7 @@
#include <stdint.h>
#include <acpi/acpi_pld.h>
#include <uuid.h>
#include "ssdb.h"
#define DEFAULT_LINK_FREQ 450000000
#define MAX_PWDB_ENTRIES 12
@ -33,43 +34,6 @@
#define SEQ_OPS_GPIO_DISABLE(ind, delay) \
{ .type = GPIO, .index = (ind), .action = DISABLE, .delay_ms = (delay) }
enum camera_device_type {
DEV_TYPE_SENSOR = 0,
DEV_TYPE_VCM,
DEV_TYPE_ROM
};
enum intel_camera_platform_type {
PLATFORM_BXT = 8,
PLATFORM_SKC = 9,
PLATFORM_CNL = 10,
PLATFORM_TGL = 12,
PLATFORM_JSL = 14,
PLATFORM_ADL = 15,
PLATFORM_MTL = 16,
PLATFORM_LNL = 17
};
enum intel_camera_flash_type {
FLASH_DEFAULT = 0,
FLASH_DISABLE = 2,
FLASH_ENABLE = 3
};
enum intel_camera_led_type {
PRIVACY_LED_DEFAULT = 0,
PRIVACY_LED_A_16mA
};
enum intel_camera_mipi_info {
MIPI_INFO_SENSOR_DRIVER = 0,
MIPI_INFO_ACPI_DEFINED
};
#define CLK_FREQ_19_2MHZ 19200000
#define CLK_FREQ_24MHZ 24000000
#define CLK_FREQ_20MHZ 20000000
enum intel_camera_device_type {
INTEL_ACPI_CAMERA_CIO2,
INTEL_ACPI_CAMERA_IMGU,
@ -147,60 +111,6 @@ struct operation_seq {
uint8_t ops_cnt;
};
struct intel_ssdb {
uint8_t version; /* Current version */
uint8_t sensor_card_sku; /* CRD Board type */
guid_t csi2_data_stream_interface; /* CSI2 data stream GUID */
uint16_t bdf_value; /* Bus number of the host
controller */
uint32_t dphy_link_en_fuses; /* Host controller's fuses
information used to verify if
link is fused out or not */
uint32_t lanes_clock_division; /* Lanes/clock divisions per
sensor */
uint8_t link_used; /* Link used by this sensor
stream */
uint8_t lanes_used; /* Number of lanes connected for
the sensor */
uint32_t csi_rx_dly_cnt_termen_clane; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_clane; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_termen_dlane0; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_dlane0; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_termen_dlane1; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_dlane1; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_termen_dlane2; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_dlane2; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_termen_dlane3; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_dlane3; /* MIPI timing information */
uint32_t max_lane_speed; /* Maximum lane speed for
the sensor */
uint8_t sensor_cal_file_idx; /* Legacy field for sensor
calibration file index */
uint8_t sensor_cal_file_idx_mbz[3]; /* Legacy field for sensor
calibration file index */
uint8_t rom_type; /* NVM type of the camera
module */
uint8_t vcm_type; /* VCM type of the camera
module */
uint8_t platform; /* Platform information */
uint8_t platform_sub; /* Platform sub-categories */
uint8_t flash_support; /* Enable/disable flash
support */
uint8_t privacy_led; /* Privacy LED support */
uint8_t degree; /* Camera Orientation */
uint8_t mipi_define; /* MIPI info defined in ACPI or
sensor driver */
uint32_t mclk_speed; /* Clock info for sensor */
uint8_t control_logic_id; /* PMIC device node used for
the camera sensor */
uint8_t mipi_data_format; /* MIPI data format */
uint8_t silicon_version; /* Silicon version */
uint8_t customer_id; /* Customer ID */
uint8_t mclk_port;
uint8_t reserved[13]; /* Pads SSDB out so the binary blob in ACPI is
the same size as seen on other firmwares.*/
} __packed;
struct intel_pwdb {
char name[32]; /* Name of the resource required by the power
action */

100
src/drivers/intel/mipi_camera/ssdb.h Normal file
View file

@ -0,0 +1,100 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#ifndef __INTEL_MIPI_CAMERA_SSDB_H__
#define __INTEL_MIPI_CAMERA_SSDB_H__
#include <stdint.h>
#include <uuid.h>
enum camera_device_type {
DEV_TYPE_SENSOR = 0,
DEV_TYPE_VCM,
DEV_TYPE_ROM
};
enum intel_camera_platform_type {
PLATFORM_BXT = 8,
PLATFORM_SKC = 9,
PLATFORM_CNL = 10,
PLATFORM_TGL = 12,
PLATFORM_JSL = 14,
PLATFORM_ADL = 15,
PLATFORM_MTL = 16,
PLATFORM_LNL = 17
};
enum intel_camera_flash_type {
FLASH_DEFAULT = 0,
FLASH_DISABLE = 2,
FLASH_ENABLE = 3
};
enum intel_camera_led_type {
PRIVACY_LED_DEFAULT = 0,
PRIVACY_LED_A_16mA
};
enum intel_camera_mipi_info {
MIPI_INFO_SENSOR_DRIVER = 0,
MIPI_INFO_ACPI_DEFINED
};
#define CLK_FREQ_19_2MHZ 19200000
#define CLK_FREQ_24MHZ 24000000
#define CLK_FREQ_20MHZ 20000000
struct intel_ssdb {
uint8_t version; /* Current version */
uint8_t sensor_card_sku; /* CRD Board type */
guid_t csi2_data_stream_interface; /* CSI2 data stream GUID */
uint16_t bdf_value; /* Bus number of the host
controller */
uint32_t dphy_link_en_fuses; /* Host controller's fuses
information used to verify if
link is fused out or not */
uint32_t lanes_clock_division; /* Lanes/clock divisions per
sensor */
uint8_t link_used; /* Link used by this sensor
stream */
uint8_t lanes_used; /* Number of lanes connected for
the sensor */
uint32_t csi_rx_dly_cnt_termen_clane; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_clane; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_termen_dlane0; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_dlane0; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_termen_dlane1; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_dlane1; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_termen_dlane2; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_dlane2; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_termen_dlane3; /* MIPI timing information */
uint32_t csi_rx_dly_cnt_settle_dlane3; /* MIPI timing information */
uint32_t max_lane_speed; /* Maximum lane speed for
the sensor */
uint8_t sensor_cal_file_idx; /* Legacy field for sensor
calibration file index */
uint8_t sensor_cal_file_idx_mbz[3]; /* Legacy field for sensor
calibration file index */
uint8_t rom_type; /* NVM type of the camera
module */
uint8_t vcm_type; /* VCM type of the camera
module */
uint8_t platform; /* Platform information */
uint8_t platform_sub; /* Platform sub-categories */
uint8_t flash_support; /* Enable/disable flash
support */
uint8_t privacy_led; /* Privacy LED support */
uint8_t degree; /* Camera Orientation */
uint8_t mipi_define; /* MIPI info defined in ACPI or
sensor driver */
uint32_t mclk_speed; /* Clock info for sensor */
uint8_t control_logic_id; /* PMIC device node used for
the camera sensor */
uint8_t mipi_data_format; /* MIPI data format */
uint8_t silicon_version; /* Silicon version */
uint8_t customer_id; /* Customer ID */
uint8_t mclk_port;
uint8_t reserved[13]; /* Pads SSDB out so the binary blob in ACPI is
the same size as seen on other firmwares.*/
} __packed;
#endif