erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/qualcomm/x1p42100/usb: Fix code comments and debug messages

Browse source 
Fix code comments and debug messages.

BUG=none
TEST=Build Google/Quenbi.

Debug logs:
```
[INFO ]  Setting up USB HOST0 controller.
[DEBUG]  USB HS PHY initialized for index 0
[DEBUG]  USB HS PHY initialized for index 1
[DEBUG]  QMP PHY MP0 init
[DEBUG]  QMP PHY MP0 initialized and locked in 1674us
[DEBUG]  QMP PHY MP1 init
[DEBUG]  QMP PHY MP1 initialized and locked in 1674us
[SPEW ]  Configure USB in Host mode
[INFO ]  DWC3 and PHY setup finished
```

Change-Id: If606a247657ffe39203101a5ff38439348deba29
Signed-off-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/89188
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kapil Porwal 2025-09-16 08:25:38 +05:30 • committed by Matt DeVillier
commit a3b73464b5
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/soc/qualcomm/x1p42100/usb/qmpv4_usb_phy.c
View file

@ -463,7 +463,7 @@ static bool ss_qmp_phy_init_common(const struct ss_usb_phy_reg *ss_phy_reg)
udelay(100);
/*
* Wait for PHY initialization to be done
* PCS_STATUS: wait for 1ms for PHY STATUS;
* PCS_STATUS: wait for 10ms for PHY STATUS;
* SW can continuously check for PHYSTATUS = 1.b0.
*/
long lock_us = wait_us(10000,
@ -471,7 +471,8 @@ static bool ss_qmp_phy_init_common(const struct ss_usb_phy_reg *ss_phy_reg)
USB3_PCS_PHYSTATUS));
if (!lock_us) {
ret = false;
printk(BIOS_ERR, "QMP PHY %s PLL LOCK fails:\n", ss_phy_reg->name);
printk(BIOS_ERR, "QMP PHY %s PLL LOCK failed after %ldus\n",
ss_phy_reg->name, lock_us);
} else {
printk(BIOS_DEBUG, "QMP PHY %s initialized and locked in %ldus\n",
ss_phy_reg->name, lock_us);
@ -479,8 +480,10 @@ static bool ss_qmp_phy_init_common(const struct ss_usb_phy_reg *ss_phy_reg)
return ret;
}
/* Unified ss_qmp_phy_init function to initialize a specific PHY instance
Pass 0 for MP0, or 1 for MP1. */
/*
* Unified ss_qmp_phy_init function to initialize a specific PHY
* instance. Pass 0 for MP0 and 1 for MP1.
*/
bool ss_qmp_phy_init(u32 phy_idx)
{
bool ret = true;