From a3b73464b5144e6d960f72a79d2d988bd331199d Mon Sep 17 00:00:00 2001 From: Kapil Porwal Date: Tue, 16 Sep 2025 08:25:38 +0530 Subject: [PATCH] soc/qualcomm/x1p42100/usb: Fix code comments and debug messages Fix code comments and debug messages. BUG=none TEST=Build Google/Quenbi. Debug logs: ``` [INFO ] Setting up USB HOST0 controller. [DEBUG] USB HS PHY initialized for index 0 [DEBUG] USB HS PHY initialized for index 1 [DEBUG] QMP PHY MP0 init [DEBUG] QMP PHY MP0 initialized and locked in 1674us [DEBUG] QMP PHY MP1 init [DEBUG] QMP PHY MP1 initialized and locked in 1674us [SPEW ] Configure USB in Host mode [INFO ] DWC3 and PHY setup finished ``` Change-Id: If606a247657ffe39203101a5ff38439348deba29 Signed-off-by: Kapil Porwal Reviewed-on: https://review.coreboot.org/c/coreboot/+/89188 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/soc/qualcomm/x1p42100/usb/qmpv4_usb_phy.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/soc/qualcomm/x1p42100/usb/qmpv4_usb_phy.c b/src/soc/qualcomm/x1p42100/usb/qmpv4_usb_phy.c index 38556b8b4d..0f85389828 100644 --- a/src/soc/qualcomm/x1p42100/usb/qmpv4_usb_phy.c +++ b/src/soc/qualcomm/x1p42100/usb/qmpv4_usb_phy.c @@ -463,7 +463,7 @@ static bool ss_qmp_phy_init_common(const struct ss_usb_phy_reg *ss_phy_reg) udelay(100); /* * Wait for PHY initialization to be done - * PCS_STATUS: wait for 1ms for PHY STATUS; + * PCS_STATUS: wait for 10ms for PHY STATUS; * SW can continuously check for PHYSTATUS = 1.b0. */ long lock_us = wait_us(10000, @@ -471,7 +471,8 @@ static bool ss_qmp_phy_init_common(const struct ss_usb_phy_reg *ss_phy_reg) USB3_PCS_PHYSTATUS)); if (!lock_us) { ret = false; - printk(BIOS_ERR, "QMP PHY %s PLL LOCK fails:\n", ss_phy_reg->name); + printk(BIOS_ERR, "QMP PHY %s PLL LOCK failed after %ldus\n", + ss_phy_reg->name, lock_us); } else { printk(BIOS_DEBUG, "QMP PHY %s initialized and locked in %ldus\n", ss_phy_reg->name, lock_us); @@ -479,8 +480,10 @@ static bool ss_qmp_phy_init_common(const struct ss_usb_phy_reg *ss_phy_reg) return ret; } -/* Unified ss_qmp_phy_init function to initialize a specific PHY instance -Pass 0 for MP0, or 1 for MP1. */ +/* + * Unified ss_qmp_phy_init function to initialize a specific PHY + * instance. Pass 0 for MP0 and 1 for MP1. + */ bool ss_qmp_phy_init(u32 phy_idx) { bool ret = true;