erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/mediatek/mt8196: Set SPMI-P SCL/SDA pins to pull-down

Browse source 
The current Pull-Down capabilities of the SPMI are insufficient and
require optimization. Configure the SCL and SDA of the SPMI-P to
Pull-Down mode on MT8196 SoC side. It is done only once during the SPMI
read check to fix SPMI clock calibration failure.

TEST=Build pass
BUG=b:361174333

Change-Id: Idbf8ed8e31850ca81c823db1b25bde4a83a48c4f
Signed-off-by: Hope Wang <hope.wang@mediatek.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85751
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Reviewed-by: Yidi Lin <yidilin@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Hope Wang 2024-08-30 15:49:09 +08:00 • committed by Yidi Lin
commit a1f97b93c6
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/soc/mediatek/mt8196/pmif_spmi.c
View file

@ -167,6 +167,9 @@ void pmif_spmi_iocfg(void)
/* SPMI_P 14mA */
gpio_set_driving(GPIO(SPMI_P_SCL), GPIO_DRV_14_MA);
gpio_set_driving(GPIO(SPMI_P_SDA), GPIO_DRV_14_MA);
/* SPMI-P set Pull-Down mode */
gpio_set_pull(GPIO(SPMI_P_SCL), GPIO_PULL_ENABLE, GPIO_PULL_DOWN);
gpio_set_pull(GPIO(SPMI_P_SDA), GPIO_PULL_ENABLE, GPIO_PULL_DOWN);
printk(BIOS_INFO, "%s done\n", __func__);
}