From a1f97b93c6ddc5f21741696b04556009ad4e72bb Mon Sep 17 00:00:00 2001 From: Hope Wang Date: Fri, 30 Aug 2024 15:49:09 +0800 Subject: [PATCH] soc/mediatek/mt8196: Set SPMI-P SCL/SDA pins to pull-down The current Pull-Down capabilities of the SPMI are insufficient and require optimization. Configure the SCL and SDA of the SPMI-P to Pull-Down mode on MT8196 SoC side. It is done only once during the SPMI read check to fix SPMI clock calibration failure. TEST=Build pass BUG=b:361174333 Change-Id: Idbf8ed8e31850ca81c823db1b25bde4a83a48c4f Signed-off-by: Hope Wang Reviewed-on: https://review.coreboot.org/c/coreboot/+/85751 Reviewed-by: Yu-Ping Wu Reviewed-by: Yidi Lin Tested-by: build bot (Jenkins) --- src/soc/mediatek/mt8196/pmif_spmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/soc/mediatek/mt8196/pmif_spmi.c b/src/soc/mediatek/mt8196/pmif_spmi.c index 91f9038eff..d00afe115d 100644 --- a/src/soc/mediatek/mt8196/pmif_spmi.c +++ b/src/soc/mediatek/mt8196/pmif_spmi.c @@ -167,6 +167,9 @@ void pmif_spmi_iocfg(void) /* SPMI_P 14mA */ gpio_set_driving(GPIO(SPMI_P_SCL), GPIO_DRV_14_MA); gpio_set_driving(GPIO(SPMI_P_SDA), GPIO_DRV_14_MA); + /* SPMI-P set Pull-Down mode */ + gpio_set_pull(GPIO(SPMI_P_SCL), GPIO_PULL_ENABLE, GPIO_PULL_DOWN); + gpio_set_pull(GPIO(SPMI_P_SDA), GPIO_PULL_ENABLE, GPIO_PULL_DOWN); printk(BIOS_INFO, "%s done\n", __func__); }