board_status/getrevision.sh: Ignore non-annotated tags

Local tags (e.g. to keep track of builds) should not be used to describe
a board status report. This has happened in some cases, e.g. [1].

According to the Git 2.41.0 manual for git-describe, the '--tagged'
parameter is a way to also use any "lightweight (non-annotated) tag" in
addition to annotated tags, which are always used even without this
parameter. All coreboot release tags seem to be annotated, so this
option should be safe to drop.

[1] https://review.coreboot.org/plugins/gitiles/board-status/+/b8c47429bad5afc5cd7f798cad3dece9790a1f83

Signed-off-by: Michael Büchler <michael.buechler@posteo.net>
Change-Id: I54b302415e569a3385559cc85323ce34462042ad
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79837
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Michael Büchler 2024-01-07 12:39:53 +01:00 committed by Matt DeVillier
commit a132aba399

View file

@ -112,7 +112,7 @@ tagged_revision() {
local r
if git_is_file_tracked "$1" ; then
r=$(git describe --tags --dirty)
r=$(git describe --dirty)
else
return ${EXIT_FAILURE}
fi