From a132aba3995d2d47732afc9cb34961a3f96e65a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20B=C3=BCchler?= Date: Sun, 7 Jan 2024 12:39:53 +0100 Subject: [PATCH] board_status/getrevision.sh: Ignore non-annotated tags MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Local tags (e.g. to keep track of builds) should not be used to describe a board status report. This has happened in some cases, e.g. [1]. According to the Git 2.41.0 manual for git-describe, the '--tagged' parameter is a way to also use any "lightweight (non-annotated) tag" in addition to annotated tags, which are always used even without this parameter. All coreboot release tags seem to be annotated, so this option should be safe to drop. [1] https://review.coreboot.org/plugins/gitiles/board-status/+/b8c47429bad5afc5cd7f798cad3dece9790a1f83 Signed-off-by: Michael Büchler Change-Id: I54b302415e569a3385559cc85323ce34462042ad Reviewed-on: https://review.coreboot.org/c/coreboot/+/79837 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- util/board_status/getrevision.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/board_status/getrevision.sh b/util/board_status/getrevision.sh index ced20fc451..a982f8d815 100755 --- a/util/board_status/getrevision.sh +++ b/util/board_status/getrevision.sh @@ -112,7 +112,7 @@ tagged_revision() { local r if git_is_file_tracked "$1" ; then - r=$(git describe --tags --dirty) + r=$(git describe --dirty) else return ${EXIT_FAILURE} fi