erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drivers/i2c/generic: Remove erroneous acpigen_pop_len

Browse source 
There are one too many acpigen_pop_len calls in the code
to generate the ROTM; remove one to fix an EMERG warning:
    [EMERG] ASSERTION_ERROR: file `src/acpi/acpigen.c`, line 38

The extra acpigen_pop_len() call was added commit
45d2c3d543 ("i2c/drivers/generic: Return ROTM in a package").

Change-Id: I913022144813f7f65eac1bcb7c97656f2c513c0b
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84197
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Sean Rhodes 2024-09-03 11:16:26 +01:00 • committed by Felix Held
commit 9f6cb3e611
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/drivers/i2c/generic/generic.c
View file

@ -165,7 +165,6 @@ void i2c_generic_fill_ssdt(const struct device *dev,
acpigen_write_return_namestr("RBUF");
acpigen_pop_len();
acpigen_pop_len();
}
/* Chip Direct Mapping */