erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/pantherlake: Hardcode IOM_BASE_ADDR_MAX value

Browse source 
iasl refuses to perform an arithmetic computation in a QWordMemory
parameter and fails with the following error.

dsdt.asl   2149: 0x4010800000, ((0x4010800000 + 0x10000) - 1), 0x0,
Error    6051 -            ^ Address Min is greater than Address Max

This commit replaces the arithmetic with the result to define
IOM_BASE_ADDR_MAX.

BUG=b:348678529
TEST=Build for google/fatcat mainboard.

Change-Id: Ia5cf899b049cb8eb27b4ea30c7f3ce7a14884f16
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84216
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jeremy Compostella 2024-08-28 15:45:45 -07:00 • committed by Jérémy Compostella
commit 14292729e8
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/soc/intel/pantherlake/include/soc/iomap.h
View file

@ -82,7 +82,7 @@
*/
#define IOM_BASE_ADDR 0x4010800000
#define IOM_BASE_SIZE 0x10000
#define IOM_BASE_ADDR_MAX ((IOM_BASE_ADDR + IOM_BASE_SIZE) - 1)
#define IOM_BASE_ADDR_MAX 0x401080ffff /* ((IOM_BASE_ADDR + IOM_BASE_SIZE) - 1) */
/* I/O port address space */
#define ACPI_BASE_ADDRESS 0x1800