erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/poppy: Replace CFR enums with booleans

Browse source 
Boolean options are intended to represent generic "Enable"/"Disable"
options, but without enum options' extra bloat in the CFR structures.

Change-Id: I491f92b334d0e9f98737b94a7232e9361e86743d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91348
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2026-02-18 21:23:18 +01:00
commit 90f9d9e7c6
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/mainboard/google/poppy/cfr.c
View file

@ -6,15 +6,11 @@
#include <intelblocks/cfr.h>
#include <soc/cfr.h>
static const struct sm_object ipu_camera = SM_DECLARE_ENUM({
static const struct sm_object ipu_camera = SM_DECLARE_BOOL({
.opt_name = "ipu_camera",
.ui_name = "IPU Camera",
.ui_helptext = "Enable or disable integrated camera devices",
.default_value = true,
.values = (const struct sm_enum_value[]) {
{ "Disabled", 0 },
{ "Enabled", 1 },
SM_ENUM_VALUE_END },
#if !CONFIG(VARIANT_HAS_CAMERA_ACPI)
.flags = CFR_OPTFLAG_SUPPRESS,
#endif