From 90f9d9e7c681ae8958727729912c826ae80545a7 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 18 Feb 2026 21:23:18 +0100 Subject: [PATCH] mb/google/poppy: Replace CFR enums with booleans Boolean options are intended to represent generic "Enable"/"Disable" options, but without enum options' extra bloat in the CFR structures. Change-Id: I491f92b334d0e9f98737b94a7232e9361e86743d Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/91348 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/google/poppy/cfr.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mainboard/google/poppy/cfr.c b/src/mainboard/google/poppy/cfr.c index 01793c080c..40bc75656f 100644 --- a/src/mainboard/google/poppy/cfr.c +++ b/src/mainboard/google/poppy/cfr.c @@ -6,15 +6,11 @@ #include #include -static const struct sm_object ipu_camera = SM_DECLARE_ENUM({ +static const struct sm_object ipu_camera = SM_DECLARE_BOOL({ .opt_name = "ipu_camera", .ui_name = "IPU Camera", .ui_helptext = "Enable or disable integrated camera devices", .default_value = true, - .values = (const struct sm_enum_value[]) { - { "Disabled", 0 }, - { "Enabled", 1 }, - SM_ENUM_VALUE_END }, #if !CONFIG(VARIANT_HAS_CAMERA_ACPI) .flags = CFR_OPTFLAG_SUPPRESS, #endif