erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ec/google/chromeec/cfr: Fix CFR callback signatures

Browse source 
Commit 04778ddd38 ("drivers/option/cfr: Remove old sm_object from
constructor") updated the function signature for CFR callbacks, but the
commits adding the fan and backlight controls were merged afterwards
without being adjusted accordingly. Do so here.

TEST=build/boot google/link with these CFR options enabled.

Change-Id: I9ea5224a820b014c4c8edb93e8a6b336ea6f58d0
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90158
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Caveh Jalali <caveh@chromium.org>
This commit is contained in:
Matt DeVillier 2025-11-23 18:01:17 -06:00
commit 87f8d15c87
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ec/google/chromeec/cfr.h
View file

@ -10,7 +10,7 @@
#include <drivers/option/cfr_frontend.h>
#include "ec.h"
static void update_fan_control(const struct sm_object *obj, struct sm_object *new)
static void update_fan_control(struct sm_object *new)
{
if (!CONFIG(EC_GOOGLE_CHROMEEC_AUTO_FAN_CTRL) && !google_chromeec_has_fan()) {
new->sm_bool.flags = CFR_OPTFLAG_SUPPRESS;
@ -38,7 +38,7 @@ static const struct sm_enum_value ec_backlight_values[] = {
SM_ENUM_VALUE_END,
};
static void update_kb_backlight(const struct sm_object *obj, struct sm_object *new)
static void update_kb_backlight(struct sm_object *new)
{
if (!google_chromeec_has_kbbacklight()) {
new->sm_bool.flags = CFR_OPTFLAG_SUPPRESS;