From 87f8d15c872d87a12027adea8e41b6cef543f994 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 23 Nov 2025 18:01:17 -0600 Subject: [PATCH] ec/google/chromeec/cfr: Fix CFR callback signatures Commit 04778ddd3814 ("drivers/option/cfr: Remove old sm_object from constructor") updated the function signature for CFR callbacks, but the commits adding the fan and backlight controls were merged afterwards without being adjusted accordingly. Do so here. TEST=build/boot google/link with these CFR options enabled. Change-Id: I9ea5224a820b014c4c8edb93e8a6b336ea6f58d0 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/90158 Tested-by: build bot (Jenkins) Reviewed-by: Caveh Jalali --- src/ec/google/chromeec/cfr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ec/google/chromeec/cfr.h b/src/ec/google/chromeec/cfr.h index 980ac120c4..93b5bd0d78 100644 --- a/src/ec/google/chromeec/cfr.h +++ b/src/ec/google/chromeec/cfr.h @@ -10,7 +10,7 @@ #include #include "ec.h" -static void update_fan_control(const struct sm_object *obj, struct sm_object *new) +static void update_fan_control(struct sm_object *new) { if (!CONFIG(EC_GOOGLE_CHROMEEC_AUTO_FAN_CTRL) && !google_chromeec_has_fan()) { new->sm_bool.flags = CFR_OPTFLAG_SUPPRESS; @@ -38,7 +38,7 @@ static const struct sm_enum_value ec_backlight_values[] = { SM_ENUM_VALUE_END, }; -static void update_kb_backlight(const struct sm_object *obj, struct sm_object *new) +static void update_kb_backlight(struct sm_object *new) { if (!google_chromeec_has_kbbacklight()) { new->sm_bool.flags = CFR_OPTFLAG_SUPPRESS;