erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/cannonlake: Use common ACPI code for SRAM and HECI

Browse source 
Use the newly-created ACPI devices in common/acpi, and adjust the
SoC ACPI name for the CSE/HECI device to match.

Change-Id: Id7b68e7c5ed554639dc14e837e311552c3ff92f0
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86815
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Matt DeVillier 2025-03-11 10:05:05 -05:00
commit 7b4110b1bf
3 changed files with 7 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/soc/intel/cannonlake/acpi/pcie.asl
View file

@ -521,13 +521,3 @@ Device (RP24)
}
}
#endif
Device (SRAM)
{
Name (_ADR, 0x00140002)
}
Device (CSE1)
{
Name (_ADR, 0x00160000)
}

6
src/soc/intel/cannonlake/acpi/southbridge.asl
View file

@ -34,6 +34,12 @@
/* USB XHCI 0:14.0 */
#include "xhci.asl"
/* PMC Shared SRAM 0:14.2 */
#include <soc/intel/common/block/acpi/acpi/sram.asl>
/* CSE/HECI #1 0:16.0 */
#include <soc/intel/common/block/acpi/acpi/heci.asl>
/* PCI _OSC */
#include <soc/intel/common/acpi/pci_osc.asl>

2
src/soc/intel/cannonlake/chip.c
View file

@ -90,7 +90,7 @@ const char *soc_acpi_name(const struct device *dev)
case PCH_DEVFN_I2C1: return "I2C1";
case PCH_DEVFN_I2C2: return "I2C2";
case PCH_DEVFN_I2C3: return "I2C3";
case PCH_DEVFN_CSE: return "CSE1";
case PCH_DEVFN_CSE: return "HECI";
case PCH_DEVFN_CSE_2: return "CSE2";
case PCH_DEVFN_CSE_IDER: return "CSED";
case PCH_DEVFN_CSE_KT: return "CSKT";